Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112804: Clamping timeout value for _PySemaphore_PlatformWait #124914

Merged
merged 3 commits into from
Oct 5, 2024
Merged

gh-112804: Clamping timeout value for _PySemaphore_PlatformWait #124914

merged 3 commits into from
Oct 5, 2024
+8 −1

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 3, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 3, 2024
Closed
corona10
corona10 commented Oct 3, 2024
View reviewed changes
Python/parking_lot.c Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Oct 3, 2024
View reviewed changes
Python/parking_lot.c Outdated Show resolved Hide resolved
vstinner
vstinner approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10
Copy link
Member Author

corona10 commented Oct 3, 2024

Let's wait @colesbury review too :)

@corona10 corona10 added the needs backport to 3.13 bugs and security fixes label Oct 3, 2024
@corona10 corona10 merged commit a5fc509 into python:main Oct 5, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2024
@corona10 @miss-islington
pythongh-112804: Clamping timeout value for _PySemaphore_PlatformWait (…
8a79c85 
…pythongh-124914)

* pythongh-112804: Clamping timeout value for _PySemaphore_PlatformWait

* Address code review

* nit
(cherry picked from commit a5fc509)

Co-authored-by: Donghee Na <donghee.na@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 5, 2024

GH-124991 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 5, 2024
corona10 added a commit to miss-islington/cpython that referenced this pull request Oct 7, 2024
@corona10
pythongh-112804: Clamping timeout value for _PySemaphore_PlatformWait (…
d9b34fe 
…pythongh-124914)

* pythongh-112804: Clamping timeout value for _PySemaphore_PlatformWait

* Address code review

* nit
(cherry picked from commit a5fc509)

Co-authored-by: Donghee Na <donghee.na@python.org>
@corona10 corona10 deleted the gh-112804 branch October 7, 2024 16:33
corona10 added a commit that referenced this pull request Oct 7, 2024
@miss-islington @corona10
[3.13] gh-112804: Clamping timeout value for _PySemaphore_PlatformWait (
80ba17a 
gh-124914) (gh-124991)

gh-112804: Clamping timeout value for _PySemaphore_PlatformWait (gh-124914)

* gh-112804: Clamping timeout value for _PySemaphore_PlatformWait

* Address code review

* nit
(cherry picked from commit a5fc509)

Co-authored-by: Donghee Na <donghee.na@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@colesbury colesbury Awaiting requested review from colesbury

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @vstinner