Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-121970: Extract availability into a new extension #125082

Merged
merged 4 commits into from
Oct 9, 2024
Merged

GH-121970: Extract availability into a new extension #125082

merged 4 commits into from
Oct 9, 2024

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Oct 8, 2024 •
edited by github-actions bot
Loading

This gives identical output before-and-after with SOURCE_DATE_EPOCH.

A

📚 Documentation preview 📚: https://cpython-previews--125082.org.readthedocs.build/

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Oct 8, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 8, 2024
Open
@hugovk
Copy link
Member

hugovk commented Oct 8, 2024

Is the point here that it's easier to reason about as a standalone extension, rather than everything being in one big pyspecific.py file?

@AA-Turner
Copy link
Member Author

Indeed, and also allows for more gradual improvement towards type hints & linting.

We already had a patchy approach with some standalone extensions and a massive pyspecific file, the intended end goal is that each extension is self contained.

pyspecific will probably remain, but will just contain the monkey-patches we apply to Sphinx/Docutils.

A

@AA-Turner AA-Turner requested a review from hugovk October 9, 2024 06:42
hugovk
hugovk reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick with the (mostly) double quotes from the original (and change the couple of singles into double).

PEP 8 says "In Python, single-quoted strings and double-quoted strings are the same. This PEP does not make a recommendation for this. Pick a rule and stick to it."

@AA-Turner AA-Turner requested a review from hugovk October 9, 2024 20:14
hugovk
hugovk approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AA-Turner AA-Turner merged commit cbfd392 into python:main Oct 9, 2024
25 checks passed
@AA-Turner AA-Turner deleted the docs/availability branch October 9, 2024 20:50
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cbfd39247983309a9ef0ae6da6c61cc71665b967 3.13

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cbfd39247983309a9ef0ae6da6c61cc71665b967 3.12

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Oct 10, 2024
@AA-Turner
[3.13] pythonGH-121970: Extract availability into a new extension (…
3f403f0 
…pythonGH-125082)

(cherry picked from commit cbfd392)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2024

GH-125237 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 10, 2024
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Oct 10, 2024
@AA-Turner
[3.12] pythonGH-121970: Extract availability into a new extension (…
b688709 
…pythonGH-125082)

(cherry picked from commit cbfd392)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2024

GH-125238 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 10, 2024
AA-Turner added a commit that referenced this pull request Oct 10, 2024
@AA-Turner
[3.12] GH-121970: Extract availability into a new extension (GH-1…
caa4924 
…25082) (#125238)

(cherry picked from commit cbfd392)
AA-Turner added a commit that referenced this pull request Oct 10, 2024
@AA-Turner
[3.13] GH-121970: Extract availability into a new extension (GH-1…
abb01fd 
…25082) (#125237)

(cherry picked from commit cbfd392)
@rffontenelle rffontenelle mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees

@AA-Turner AA-Turner

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @hugovk