Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36345: Add a new example in the documentation of wsgiref #12511

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

matrixise
Copy link
Member

@matrixise matrixise commented Mar 23, 2019

It's the second PR where I convert the code of Tools/scripts/serve.py as an example in the documentation of wsgiref.

https://bugs.python.org/issue36345

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. IMO should be good tell how the example is executed.

@brettcannon
Copy link
Member

One minor change and then we can merge this! (I tried to merge it myself but you didn't give repo owners edit rights on your PRs, @matrixise ).

Co-Authored-By: matrixise <stephane@wirtel.be>
@matrixise
Copy link
Member Author

Thank you so much @brettcannon , About the rights, this is strange because I just create this PR and I think the flag was checked. really sorry.

@brettcannon brettcannon merged commit 360e1e4 into python:master Mar 25, 2019
@bedevere-bot
Copy link

@brettcannon: Please replace # with GH- in the commit message next time. Thanks!

@brettcannon
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants