Skip to content

gh-85935: Explicitly document the case nargs=0 in argparse #125302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2024
Merged

gh-85935: Explicitly document the case nargs=0 in argparse #125302

merged 2 commits into from
Oct 12, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 11, 2024 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 11, 2024
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 11, 2024
Merged
@savannahostrowski savannahostrowski changed the title gh-85935: Excplicitly document the case nargs=0 in argparse gh-85935: Explicitly document the case nargs=0 in argparse Oct 11, 2024
savannahostrowski
savannahostrowski requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments for conciseness, but otherwise, LGTM.

@serhiy-storchaka @savannahostrowski
Apply suggestions from code review
81660a4 
Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) October 12, 2024 11:35
@serhiy-storchaka serhiy-storchaka merged commit 07c2d15 into python:main Oct 12, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2024
@serhiy-storchaka @miss-islington
pythongh-85935: Explicitly document the case nargs=0 in argparse (pyt…
3b39977 
…honGH-125302)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2024
@serhiy-storchaka @miss-islington
pythongh-85935: Explicitly document the case nargs=0 in argparse (pyt…
eaaf23c 
…honGH-125302)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 12, 2024

GH-125357 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 12, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 12, 2024

GH-125358 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 12, 2024
serhiy-storchaka added a commit that referenced this pull request Oct 12, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-85935: Explicitly document the case nargs=0 in argparse (GH…
e01a178 
…-125302) (GH-125358)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 12, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-85935: Explicitly document the case nargs=0 in argparse (GH…
0542645 
…-125302) (GH-125357)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the argparse-nargs-0-docs branch October 21, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savannahostrowski savannahostrowski savannahostrowski requested changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @savannahostrowski