Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123465: Ensure PyType_FromMetaclass avoids extra strcmp #125460

Merged
merged 2 commits into from
Nov 13, 2024
Merged

gh-123465: Ensure PyType_FromMetaclass avoids extra strcmp #125460

merged 2 commits into from
Nov 13, 2024

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Oct 14, 2024 •
edited by bedevere-app bot
Loading

@neonene neonene requested a review from markshannon as a code owner October 14, 2024 15:02
@bedevere-app bedevere-app bot mentioned this pull request Oct 14, 2024
Closed
@neonene
Copy link
Contributor Author

neonene commented Nov 13, 2024

@encukou Could you judge the change? This still helps the latest VS2022 (17.12) and VS2019 (16.11.42) to avoid a weird crash after the if branches were moved down (16be8db). But I don't have a strong opinion, as it won't hurt anyone except when using a minor diagnose option.

@encukou
Copy link
Member

encukou commented Nov 13, 2024

Sure! Thanks for the ping :)

@encukou encukou enabled auto-merge (squash) November 13, 2024 16:44
@encukou encukou merged commit 8c9c6d3 into python:main Nov 13, 2024
37 checks passed
@neonene neonene deleted the strcmps branch November 14, 2024 03:23
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@neonene @picnixz
pythongh-123465: Ensure PyType_FromMetaclass avoids extra strcmp (pyt…
924be80 
…honGH-125460)

use else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neonene @encukou @tomasr8 @picnixz