-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Bump Python to 3.13 and mypy to 1.12 in mypy workflow #125592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A big +1 from me :)
FYI: There is a PR which failed due to Python 3.11 in the mypy workflow: #125589 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that "supporting" a version in the mypy issue tracker is often a bit of a misnomer. Mypy has long supported running on Python 3.12 fine; it just may not necessarily have good support for type checking all new features in Python 3.12.
We could even run it on 3.13 if we update to the latest mypy release (1.12). |
(Mypy will still reject new-in-Python 3.12 features in some of the various directories it checks, even with this change, without changes such as the one Pablo is proposing to make to the |
You get to remove a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do you think this should be backported to 3.13? |
If it backports cleanly, it's nice to have a consistent "CI experience" between the actively maintained branches. But I also wouldn't spend too much time on it if it doesn't backport cleanly :-) |
Thanks @Eclips4 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @Eclips4, I could not cleanly backport this to
|
GH-125596 is a backport of this pull request to the 3.13 branch. |
…honGH-125592) * Bump mypy to 1.12 & Python to 3.13 * Remove unnecessary `type: ignore` (cherry picked from commit d83fcf8) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Talking about the 3.12 branch, I'm not sure if this should be done there. Running mypy on the 3.13 version may give false positives for the 3.12 version, so... what do you think? |
As long as the |
Thanks @Eclips4 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, @Eclips4, I could not cleanly backport this to
|
…honGH-125592) * Bump mypy to 1.12 & Python to 3.13 * Remove unnecessary `type: ignore` (cherry picked from commit d83fcf8) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
I think that we're ready to bump python to 3.12 in mypy workflow, from what I can see at python/mypy#15277, mypy almost supports 3.12 except for python/mypy#15313.