Skip to content

GH-125912: Teach the optimizer about _BINARY_OP_INPLACE_ADD_UNICODE #125935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

GH-125912: Teach the optimizer about _BINARY_OP_INPLACE_ADD_UNICODE #125935

merged 1 commit into from
Oct 28, 2024

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Oct 24, 2024 •
edited by bedevere-app bot
Loading

Mostly just copied from _BINARY_OP_INPLACE_ADD and _STORE_FAST

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT labels Oct 24, 2024
@brandtbucher brandtbucher self-assigned this Oct 24, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 24, 2024
Closed
rruuaanng
rruuaanng approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@rruuaanng rruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtbucher brandtbucher merged commit b5b0634 into python:main Oct 28, 2024
65 checks passed
@brandtbucher brandtbucher mentioned this pull request Oct 29, 2024
Open
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@brandtbucher @picnixz
pythonGH-125912: Teach the JIT's optimizer about _BINARY_OP_INPLACE_A…
06c5b0c 
…DD_UNICODE (pythonGH-125935)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@brandtbucher @ebonnal
pythonGH-125912: Teach the JIT's optimizer about _BINARY_OP_INPLACE_A…
925915e 
…DD_UNICODE (pythonGH-125935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@rruuaanng rruuaanng rruuaanng approved these changes

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news topic-JIT type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandtbucher @Fidget-Spinner @rruuaanng