-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-126212: Fix removal of slashes in file URIs on Windows #126214
Conversation
Adjust `urllib.request.pathname2url()` and `url2pathname()` so that they don't remove slashes from Windows DOS drive paths and URLs. There was no basis for this behaviour, and it conflicts with how UNC and POSIX paths are handled.
Hey @zooba, hope I'm not being rude with the ping, just wondering if you intend to review again? If so I'm happy to wait! Thanks |
It's not rude, but it's also not helpful :) Pings don't reach me any quicker than regular notifications. This looks good to me. Thanks! |
Thanks for the review! I pinged because you approved a closely-related PR at the same time, and I thought there might have been a mix-up between the two as you were so quick to reply initially. My mistake - I'm sorry for the noise. And thanks again. |
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…onGH-126214) Adjust `urllib.request.pathname2url()` and `url2pathname()` so that they don't remove slashes from Windows DOS drive paths and URLs. There was no basis for this behaviour, and it conflicts with how UNC and POSIX paths are handled. (cherry picked from commit 54c63a3) Co-authored-by: Barney Gale <barney.gale@gmail.com>
GH-126590 is a backport of this pull request to the 3.13 branch. |
…onGH-126214) Adjust `urllib.request.pathname2url()` and `url2pathname()` so that they don't remove slashes from Windows DOS drive paths and URLs. There was no basis for this behaviour, and it conflicts with how UNC and POSIX paths are handled. (cherry picked from commit 54c63a3) Co-authored-by: Barney Gale <barney.gale@gmail.com>
GH-126591 is a backport of this pull request to the 3.12 branch. |
…126214) (#126591) GH-126212: Fix removal of slashes in file URIs on Windows (GH-126214) Adjust `urllib.request.pathname2url()` and `url2pathname()` so that they don't remove slashes from Windows DOS drive paths and URLs. There was no basis for this behaviour, and it conflicts with how UNC and POSIX paths are handled. (cherry picked from commit 54c63a3) Co-authored-by: Barney Gale <barney.gale@gmail.com>
…126214) (#126590) GH-126212: Fix removal of slashes in file URIs on Windows (GH-126214) Adjust `urllib.request.pathname2url()` and `url2pathname()` so that they don't remove slashes from Windows DOS drive paths and URLs. There was no basis for this behaviour, and it conflicts with how UNC and POSIX paths are handled. (cherry picked from commit 54c63a3) Co-authored-by: Barney Gale <barney.gale@gmail.com>
Adjust
urllib.request.pathname2url()
andurl2pathname()
so that they don't remove slashes from Windows DOS drive paths and URLs. There was no basis for this behaviour, and it conflicts with how UNC and POSIX paths are handled.