gh-126220: Fix crash on calls to _lsprof.Profiler methods with 0 args (backportable)
#126271
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
needs backport to 3.12
picnixz
changed the title
_lsprof.Profiler methods with 0 args_lsprof.Profiler methods with 0 args (backportable)
|
I'm changing the title of the PR just so that we don't have two PRs that look exactly the same on the issue. |
Misc/NEWS.d/next/Library/2024-10-31-14-06-28.gh-issue-126220.uJAJCU.rst
Outdated
Show resolved
Hide resolved
erlend-aasland
approved these changes
Nov 1, 2024
…JAJCU.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 1, 2024
…h 0 args (backportable) (pythonGH-126271) (cherry picked from commit 28b148f) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 1, 2024
…h 0 args (backportable) (pythonGH-126271) (cherry picked from commit 28b148f) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
GH-126310 is a backport of this pull request to the 3.13 branch. |
|
GH-126311 is a backport of this pull request to the 3.12 branch. |
|
Thank you! I will backport this change and go back to the original PR soon :) |
Next time, remember to edit such a change out of the squashed commit title ;) |
|
Nit: ideally, the other PR would have received the title change (adapt to Argument Clinic ...), not this one. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…h 0 args (backportable) (python#126271) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…h 0 args (backportable) (python#126271) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix with no AC that we can backport.
#126233 will be reworked to only apply AC to already fixed functions. I plan to merge this one first and then rebase the oirginal one.
_lsprof.Profiler._creturn_callback()segfaults #126220