gh-126349 Add context managers to turtle for `fill`, `poly` and `no_animation` #126350

MarieRoald · 2024-11-03T05:59:33Z

Adds fill(), poly() and no_animation() context managers to turtle.py.

Co-authored-by: Yngve Mardal Moe 3531982+yngvem@users.noreply.github.com

Issue: Turtle context managers for fill, poly and tracer #126349

📚 Documentation preview 📚: https://cpython-previews--126350.org.readthedocs.build/en/126350/library/turtle.html

Co-authored-by: Marie Roald <roald.marie@gmail.com>

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

Co-authored-by: Marie Roald <roald.marie@gmail.com>

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

Wulian233 · 2024-11-03T09:14:54Z

LGTM
Recommend adding to what's new 3.14.rst

Lib/turtle.py

Eclips4

Could you please add a note about these additions to the Doc/whatsnew/3.14.rst?

Doc/library/turtle.rst

hugovk · 2024-11-03T17:57:13Z

Doc/library/turtle.rst

+Automatically begin and end filling
+-----------------------------------
+
+If you have Python 3.14 or later, you don't need to call :func:`begin_fill` and


We don't usually include things like "If you have Python 3.14 or later" because each set of docs relates to one specific Python version.

But perhaps it's okay here because turtle is often used by beginners who might read these docs but have 3.12 or 3.13 installed?

That makes a lot of sense, but in this specific case I think it's useful. Many learners are at universities or schools with old versions of Python, and they might not be aware that there are several versions of Python. So I think it's useful to make it very clear that this is a new feature.

Sorry to reopen, but IMO this reads a little bit unexpected. How about something in the lines of:

Starting with Python 3.14, you can use [...] instead of [...].

What do you think?

Doc/library/turtle.rst

Lib/turtle.py

Lib/test/test_turtle.py

Lib/turtle.py

danielhollas · 2024-11-05T02:47:43Z

Lib/turtle.py

@@ -110,27 +110,30 @@
 from copy import deepcopy
 from tkinter import simpledialog

+from contextlib import contextmanager


Why the extra newline between this and the previous import statement?

Doc/library/turtle.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Daniel Hollas <danekhollas@gmail.com>

Doc/library/turtle.rst

Lib/test/test_turtle.py

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Daniel Hollas <danekhollas@gmail.com>

Doc/whatsnew/3.14.rst

yngvem · 2024-11-08T19:00:54Z

We have tried to address the review comments now 🙂

picnixz

Some final minor nitpicks. Otherwise looks great!

Doc/whatsnew/3.14.rst

Lib/test/test_turtle.py

Lib/turtle.py

Lib/test/test_turtle.py

Doc/library/turtle.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Co-authored-by: Marie Roald <roald.marie@gmail.com>

picnixz

Last one and I am good! (modulo Hugo's comment)

Doc/library/turtle.rst

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

picnixz

I promise there really shouldn't have anything left for me. Thank you for your patience! (my reviews tend to have multiple parts depending on the hour when I do the review).

Lib/turtle.py

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

MarieRoald · 2024-11-09T20:41:35Z

I promise there really shouldn't have anything left for me. Thank you for your patience! (my reviews tend to have multiple parts depending on the hour when I do the review).

No worries, thanks a lot for the thorough review!

erlend-aasland

This looks good, but I have some remarks and nits. PTAL.

erlend-aasland · 2024-11-13T07:41:10Z

Doc/library/turtle.rst

+Automatically begin and end filling
+-----------------------------------
+
+If you have Python 3.14 or later, you don't need to call :func:`begin_fill` and


Sorry to reopen, but IMO this reads a little bit unexpected. How about something in the lines of:

Starting with Python 3.14, you can use [...] instead of [...].

What do you think?

Doc/library/turtle.rst

erlend-aasland · 2024-11-13T07:52:41Z

Doc/library/turtle.rst

+      ...     dist = 2
+      ...     for i in range(200):
+      ...         fd(dist)
+      ...         rt(90)
+      ...         dist += 2


This can also be written more compact. Though, I'm not sure it is more readable, so feel free to ignore this :)

Suggested change

... dist = 2

... for i in range(200):

... fd(dist)

... rt(90)

... dist += 2

... for dist in range(0, 400, 2):

... fd(dist+2)

... rt(90)

Lib/turtle.py

erlend-aasland · 2024-11-13T08:10:14Z

Lib/turtle.py

+        """Record the vertices of a polygon.
+
+        No argument.
+
+        Record the vertices of a polygon. Current turtle position is first point
+        of polygon. This function sets up a context manager that will
+        automatically end recording once exited.


Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

yngvem and others added 5 commits November 3, 2024 05:21

Add context managers for turtle.fill and turtle.poly

3379b3d

Co-authored-by: Marie Roald <roald.marie@gmail.com>

Add documentation

879d886

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

Add context manager to turtle.TurtleScreen for disabling auto-update

54f709c

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

Forward functions correctly

437c8ce

Co-authored-by: Marie Roald <roald.marie@gmail.com>

Add documentation

d11d8f9

Co-authored-by: Marie Roald <roald.marie@gmail.com>

This comment was marked as outdated.

Sign in to view

bedevere-app bot added the awaiting review label Nov 3, 2024

bedevere-app bot mentioned this pull request Nov 3, 2024

Turtle context managers for fill, poly and tracer #126349

Open

blurb-it bot and others added 2 commits November 3, 2024 06:05

📜🤖 Added by blurb_it.

1f04ee4

Fix typo in docs

3947de1

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

This comment was marked as off-topic.

Sign in to view

nineteendo reviewed Nov 3, 2024

View reviewed changes

Lib/turtle.py Show resolved Hide resolved

Eclips4 reviewed Nov 3, 2024

View reviewed changes

hugovk reviewed Nov 3, 2024

View reviewed changes

erlend-aasland reviewed Nov 4, 2024

View reviewed changes

Lib/test/test_turtle.py Outdated Show resolved Hide resolved

danielhollas reviewed Nov 5, 2024

View reviewed changes

Apply suggestions from code review

5ee489b

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Daniel Hollas <danekhollas@gmail.com>

picnixz reviewed Nov 8, 2024

View reviewed changes

MarieRoald and others added 2 commits November 8, 2024 18:06

Address review comments

28a5ac6

Apply suggestions from code review

6621bd3

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Daniel Hollas <danekhollas@gmail.com>

picnixz reviewed Nov 8, 2024

View reviewed changes

Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved

Address review comments

2f5c488

picnixz reviewed Nov 8, 2024

View reviewed changes

MarieRoald and others added 3 commits November 9, 2024 05:39

Apply suggestions from code review

302a1ed

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Use setUp for unit tests

ad779d5

Co-authored-by: Marie Roald <roald.marie@gmail.com>

Address review comments

fd89c95

Co-authored-by: Marie Roald <roald.marie@gmail.com>

picnixz approved these changes Nov 9, 2024

View reviewed changes

Doc/library/turtle.rst Show resolved Hide resolved

bedevere-app bot removed the awaiting review label Nov 9, 2024

bedevere-app bot added the awaiting core review label Nov 9, 2024

Add missing blank line

fe39751

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

picnixz approved these changes Nov 9, 2024

View reviewed changes

Lib/turtle.py Outdated Show resolved Hide resolved

Update Lib/turtle.py

0a5e250

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

erlend-aasland reviewed Nov 13, 2024

View reviewed changes

MarieRoald and others added 3 commits November 14, 2024 05:44

Apply suggestions from code review

6d381ec

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Update Lib/turtle.py

42d678d

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Address reviewer comments

7928306

Co-authored-by: Yngve Mardal Moe <yngve.m.moe@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-126349 Add context managers to turtle for `fill`, `poly` and `no_animation` #126350

gh-126349 Add context managers to turtle for `fill`, `poly` and `no_animation` #126350

MarieRoald commented Nov 3, 2024 •

edited by hugovk

Loading

This comment was marked as outdated.

Wulian233 commented Nov 3, 2024

This comment was marked as off-topic.

Eclips4 left a comment

hugovk Nov 3, 2024

yngvem Nov 8, 2024

erlend-aasland Nov 13, 2024

danielhollas Nov 5, 2024 •

edited

Loading

yngvem commented Nov 8, 2024

picnixz left a comment

picnixz left a comment •

edited

Loading

picnixz left a comment

MarieRoald commented Nov 9, 2024

erlend-aasland left a comment

erlend-aasland Nov 13, 2024

erlend-aasland Nov 13, 2024

erlend-aasland Nov 13, 2024

gh-126349 Add context managers to turtle for fill, poly and no_animation #126350

Are you sure you want to change the base?

gh-126349 Add context managers to turtle for fill, poly and no_animation #126350

Conversation

MarieRoald commented Nov 3, 2024 • edited by hugovk Loading

This comment was marked as outdated.

Wulian233 commented Nov 3, 2024

This comment was marked as off-topic.

Eclips4 left a comment

Choose a reason for hiding this comment

hugovk Nov 3, 2024

Choose a reason for hiding this comment

yngvem Nov 8, 2024

Choose a reason for hiding this comment

erlend-aasland Nov 13, 2024

Choose a reason for hiding this comment

danielhollas Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

yngvem commented Nov 8, 2024

picnixz left a comment

Choose a reason for hiding this comment

picnixz left a comment • edited Loading

Choose a reason for hiding this comment

picnixz left a comment

Choose a reason for hiding this comment

MarieRoald commented Nov 9, 2024

erlend-aasland left a comment

Choose a reason for hiding this comment

erlend-aasland Nov 13, 2024

Choose a reason for hiding this comment

erlend-aasland Nov 13, 2024

Choose a reason for hiding this comment

erlend-aasland Nov 13, 2024

Choose a reason for hiding this comment

gh-126349 Add context managers to turtle for `fill`, `poly` and `no_animation` #126350

gh-126349 Add context managers to turtle for `fill`, `poly` and `no_animation` #126350

MarieRoald commented Nov 3, 2024 •

edited by hugovk

Loading

danielhollas Nov 5, 2024 •

edited

Loading

picnixz left a comment •

edited

Loading