gh-126353: remove implicit creation of loop from get_event_loop
#126354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
requested review from
1st1,
asvetlov and
willingc
as code owners
kumaraditya303
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Misc/NEWS.d/next/Library/2024-11-03-10-48-07.gh-issue-126353.ChDzot.rst
Outdated
Show resolved
Hide resolved
kumaraditya303
commented
Nov 4, 2024
kumaraditya303
commented
Nov 4, 2024
asvetlov
approved these changes
Nov 4, 2024
graingert
reviewed
Nov 4, 2024
| @@ -924,7 +924,7 @@ def test_python_gil(self): | |||
| self.assertEqual(proc.stderr, '') | |||
|
|
|||
| def test_python_asyncio_debug(self): | |||
| code = "import asyncio; print(asyncio.get_event_loop().get_debug())" | |||
| code = "import asyncio; print(asyncio.new_event_loop().get_debug())" | |||
There was a problem hiding this comment.
I think this needs a with contextlib.closing(... to prevent the test suite printing a ResourceWarning
hroncok
reviewed
Nov 22, 2024
| @@ -576,6 +576,11 @@ asyncio | |||
|
|
|||
| (Contributed by Kumar Aditya in :gh:`120804`.) | |||
|
|
|||
| * Removed implicit creation of event loop by :func:`asyncio.get_event_loop`. | |||
| It now raises a :exc:`RuntimeError` if there is no current event loop. | |||
| (Contributed by Kumar Aditya in :gh:`126353`.) | |||
There was a problem hiding this comment.
Could you please mention what should be used instead?
There was a problem hiding this comment.
new_event_loop(). But these who need a new even loop already know this.
There was a problem hiding this comment.
new_event_loop is not correct, it should be asyncio.run or asyncio.Runner
Worst case it would be asyncio.EventLoop, new_event_loop uses the policy system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.get_event_loop#126353