Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update some ms link #126379

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore(docs): update some ms link #126379

merged 1 commit into from
Nov 11, 2024

Conversation

imba-tjd
Copy link
Contributor

@imba-tjd imba-tjd commented Nov 4, 2024

Primarily this PR removes language part from the url, letting server redirect to browser's language.


📚 Documentation preview 📚: https://cpython-previews--126379.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 4, 2024
@kumaraditya303 kumaraditya303 removed their request for review November 7, 2024 09:59
@picnixz picnixz requested a review from zooba November 7, 2024 11:35
@vstinner
Copy link
Member

vstinner commented Nov 7, 2024

As a French person, I prefer to get the documentation in English :-)

@zooba
Copy link
Member

zooba commented Nov 7, 2024

Your browser settings will determine which language you get, and there are going to be elements on the page to switch language (or there should be).

I agree with removing the language codes.

@zooba
Copy link
Member

zooba commented Nov 11, 2024

I hear no objections, and the links are all good (at least for me).

@zooba zooba merged commit 6e25eb1 into python:main Nov 11, 2024
34 checks passed
@zooba zooba added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 11, 2024
@miss-islington-app
Copy link

Thanks @imba-tjd for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @imba-tjd for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2024
…GH-126379)

(cherry picked from commit 6e25eb1)

Co-authored-by: 谭九鼎 <109224573@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2024
…GH-126379)

(cherry picked from commit 6e25eb1)

Co-authored-by: 谭九鼎 <109224573@qq.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 11, 2024

GH-126693 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 11, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 11, 2024

GH-126694 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 11, 2024
zooba pushed a commit that referenced this pull request Nov 11, 2024
)

(cherry picked from commit 6e25eb1)

Co-authored-by: 谭九鼎 <109224573@qq.com>
zooba pushed a commit that referenced this pull request Nov 11, 2024
)

(cherry picked from commit 6e25eb1)

Co-authored-by: 谭九鼎 <109224573@qq.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants