Skip to content

Typo fix in MAKE_FUNCTION opcode in dis library docs #126396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Eclips4 merged 1 commit into from
Nov 4, 2024
Merged

Typo fix in MAKE_FUNCTION opcode in dis library docs #126396

Eclips4 merged 1 commit into from
Nov 4, 2024

Conversation

@efimov-mikhail
Copy link
Member

@efimov-mikhail efimov-mikhail commented Nov 4, 2024 •
edited by github-actions bot
Loading

One line change in docs.

📚 Documentation preview 📚: https://cpython-previews--126396.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 4, 2024
mdboom
mdboom approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Eclips4
Eclips4 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mikhail!

@Eclips4 Eclips4 merged commit e5a4b40 into python:main Nov 4, 2024
38 checks passed
@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Nov 4, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 4, 2024

Thanks @efimov-mikhail for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 4, 2024
@efimov-mikhail @miss-islington
Doc: Fix typo in documentation for MAKE_FUNCTION opcode (pythonGH…
d0ebf36 
…-126396)

(cherry picked from commit e5a4b40)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 4, 2024

GH-126406 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 4, 2024
Eclips4 pushed a commit that referenced this pull request Nov 4, 2024
@miss-islington @efimov-mikhail
[3.13] Doc: Fix typo in documentation for MAKE_FUNCTION opcode (G…
9e72a3f 
…H-126396) (#126406)

Doc: Fix typo in documentation for  ``MAKE_FUNCTION`` opcode (GH-126396)
(cherry picked from commit e5a4b40)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
@efimov-mikhail efimov-mikhail deleted the docs_dis_make_function_typo branch November 6, 2024 15:29
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@efimov-mikhail @picnixz
Doc: Fix typo in documentation for MAKE_FUNCTION opcode (python#1…
2a9cc75 
…26396)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@efimov-mikhail @ebonnal
Doc: Fix typo in documentation for MAKE_FUNCTION opcode (python#1…
ae3ebf8 
…26396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom mdboom approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efimov-mikhail @mdboom @Eclips4