Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fullstop to whatsnew/3.8.rst #126553

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add missing fullstop to whatsnew/3.8.rst #126553

merged 1 commit into from
Nov 11, 2024

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Nov 7, 2024 •
edited
Loading

How it looks today without the fix (link to published doc):

Added a force keyword argument to logging.basicConfig() When set to true, any existing handlers attached to the root logger are removed and closed before carrying out the configuration specified by the other arguments.

Please backport it to 3.12 and 3.13.

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 7, 2024
ZeroIntensity
ZeroIntensity reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is needed. 3.8 is now EOL, I don't think we should update documentation for it.

@gpshead gpshead added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 11, 2024
@gpshead
Copy link
Member

gpshead commented Nov 11, 2024

docs, especially whatsnew, are referenced for old versions all the time as people migrate old code. thanks!

@gpshead gpshead merged commit 82269c7 into python:main Nov 11, 2024
42 checks passed
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2024
@rffontenelle @miss-islington
Add missing fullstop . to whatsnew/3.8.rst (pythonGH-126553)
c1380af 
(cherry picked from commit 82269c7)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 11, 2024

GH-126672 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 11, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2024
@rffontenelle @miss-islington
Add missing fullstop . to whatsnew/3.8.rst (pythonGH-126553)
c4c3c46 
(cherry picked from commit 82269c7)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 11, 2024

GH-126673 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 11, 2024
gpshead pushed a commit that referenced this pull request Nov 11, 2024
@miss-islington @rffontenelle
[3.13] Add missing fullstop . to whatsnew/3.8.rst (GH-126553) (#126672
90cf1af 
)

Add missing fullstop `.` to whatsnew/3.8.rst (GH-126553)
(cherry picked from commit 82269c7)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request Nov 11, 2024
@miss-islington @rffontenelle
[3.12] Add missing fullstop . to whatsnew/3.8.rst (GH-126553) (#126673
75d251b 
)

Add missing fullstop `.` to whatsnew/3.8.rst (GH-126553)
(cherry picked from commit 82269c7)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@rffontenelle @picnixz
Add missing fullstop . to whatsnew/3.8.rst (pythonGH-126553)
0488fff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rffontenelle @gpshead @ZeroIntensity