Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126662: harmonize naming for three namedtuple base classes in urllib.parse #126663

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Nov 11, 2024

This MR improves naming consistency for three private namedtuples in urllib.parse. This isn't very important, but the consistency helps typeshed. I figured I'd start MRs for gh-126662 with a low-stakes one.

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, this is basically a no-op. nobody ever sees these private base types. may as well have them line up.

@gpshead gpshead added skip news stdlib Python modules in the Lib dir labels Nov 24, 2024
@gpshead gpshead merged commit a4d4c1e into python:main Nov 24, 2024
44 checks passed
@tungol tungol deleted the naming-urllib branch November 24, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants