Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message of "Check if Autoconf files are up to date" job #126683

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix error message of "Check if Autoconf files are up to date" job #126683

merged 2 commits into from
Nov 12, 2024

Conversation

sobolevn
Copy link
Member

make regen-all does not run make regen-configure see:

cpython/Makefile.pre.in

Lines 1732 to 1733 in 9fc2808

@echo "Note: make regen-stdlib-module-names, make regen-limited-abi, "
@echo "make regen-configure, make regen-sbom, and make regen-unicodedata should be run manually"

@erlend-aasland
Copy link
Contributor

This might need to be backported.

@sobolevn sobolevn added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 12, 2024
@sobolevn
Copy link
Member Author

Yes, original PR was backported to 3.13 and 3.12: #125744

@sobolevn sobolevn merged commit 0052a8c into python:main Nov 12, 2024
45 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2024
@sobolevn @miss-islington
Fix error message of "Check if Autoconf files are up to date" job (py…
2cd5e97 
…thonGH-126683)

(cherry picked from commit 0052a8c)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

GH-126717 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2024
@sobolevn @miss-islington
Fix error message of "Check if Autoconf files are up to date" job (py…
1710b7d 
…thonGH-126683)

(cherry picked from commit 0052a8c)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 12, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

GH-126718 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 12, 2024
sobolevn added a commit that referenced this pull request Nov 12, 2024
@miss-islington @sobolevn
[3.12] Fix error message of "Check if Autoconf files are up to date" …
41873c8 
…job (GH-126683) (#126718)

Fix error message of "Check if Autoconf files are up to date" job (GH-126683)
(cherry picked from commit 0052a8c)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Nov 12, 2024
@miss-islington @sobolevn
[3.13] Fix error message of "Check if Autoconf files are up to date" …
efd8fe4 
…job (GH-126683) (#126717)

Fix error message of "Check if Autoconf files are up to date" job (GH-126683)
(cherry picked from commit 0052a8c)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @erlend-aasland