Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126662: Naming consistency for shutil._ntuple_diskusage #126723

Closed
wants to merge 1 commit into from
Closed

gh-126662: Naming consistency for shutil._ntuple_diskusage #126723

wants to merge 1 commit into from
+2 −2

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Nov 12, 2024 •
edited by bedevere-app bot
Loading

This MR updates shutil._ntuple_diskusage so it's named consistently.

@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Open
@tungol tungol marked this pull request as draft November 12, 2024 18:09
@tungol
Copy link
Contributor Author

tungol commented Nov 12, 2024

Marking this one as draft to consider: this is like #126721 in that it's a named tuple returned directly to end users, and _ntuple_diskusage is a weird looking name, so maybe this isn't the best solution to achieve consistency.

@tungol tungol closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tungol