-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126782: Support qualified referencing for ntpath.abspath()
#126784
base: main
Are you sure you want to change the base?
Conversation
…2-44-38.gh-issue-119826.Atm9ol.rst
…024-05-31-12-44-38.gh-issue-126782.Atm9ol.rst
@@ -839,6 +839,20 @@ def test_abspath(self): | |||
tester('ntpath.abspath("")', cwd_dir) | |||
tester('ntpath.abspath(" ")', cwd_dir + "\\ ") | |||
tester('ntpath.abspath("?")', cwd_dir + "\\?") | |||
tester('ntpath.abspath("con")', r"\\.\con") | |||
# bpo-45354: Windows 11 changed MS-DOS device name handling | |||
if sys.getwindowsversion()[:3] < (10, 0, 22000): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we test on Windows 10 and 11?
How close do we get just by swapping the order of the If we can't do that, I'd prefer to see more of the logic on the Python side of things, and better naming than "explicit" and "curdir". |
You get other problems (and just replacing
It's the same idea, detect whether the path contained
I'm bad at naming things, but we're doing something complicated here. It's just an internal option though.
Edit: Some other options are |
ntpath.abspath()
#126782