Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126946: Improve error message in getopt.do_longs based on existing comment #126871

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

bombs-kim
Copy link
Contributor

@bombs-kim bombs-kim commented Nov 15, 2024

This PR improves the error message in getopt.do_longs based on the existing comment

@brianschubert
Copy link
Contributor

brianschubert commented Nov 16, 2024

Since this is a user facing change, I think it will need an issue and a news entry. You can open a new issue and edit the number into the title.

If you haven't seen it already, take a look at Lifecycle of a pull request from the dev guide for specific tips on what to include in a PR for different types of changes.

@bombs-kim bombs-kim marked this pull request as draft November 17, 2024 11:05
@bombs-kim bombs-kim changed the title Improve error message in getopt.do_longs based on existing comment gh-126946: Improve error message in getopt.do_longs based on existing comment Nov 18, 2024
@bombs-kim
Copy link
Contributor Author

@brianschubert I've created an issue and added a NEWS entry.

@bombs-kim bombs-kim marked this pull request as ready for review November 18, 2024 07:45
Copy link
Contributor

@brianschubert brianschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @serhiy-storchaka for recent work on getopt

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit f46d847 into python:main Nov 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants