-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126946: Improve error message in getopt.do_longs based on existing comment #126871
Conversation
Since this is a user facing change, I think it will need an issue and a news entry. You can open a new issue and edit the number into the title. If you haven't seen it already, take a look at Lifecycle of a pull request from the dev guide for specific tips on what to include in a PR for different types of changes. |
@brianschubert I've created an issue and added a NEWS entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @serhiy-storchaka for recent work on getopt
Misc/NEWS.d/next/Library/2024-11-18-16-43-11.gh-issue-126946.52Ou-B.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
This PR improves the error message in getopt.do_longs based on the existing comment