Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-126920: fix Makefile overwriting sysconfig.get_config_vars #126922

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Nov 17, 2024

Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
Member Author

FFY00 commented Nov 17, 2024

I am not sure if we should backport this, as they may be users incorrectly relying on the value of sysconfig.get_config_var('prefix') or sysconfig.get_config_var('exec_prefix').

I think it's a low chance, but since this bug does not seem to be causing any known breakage in the first place, it may be worth considering leaving older versions with the incorrect value rather than breaking users possibly relying on the current value being incorrect.

3.13 is still pretty recent and people are still getting around to updating to it — in Arch Linux, for reference, we are only now starting the package rebuilds for Python 3.13 — so I don't think there'd be much harm in backporting. 3.12, tough, I am not sure.

@Yhg1s what do you think?

@FFY00 FFY00 merged commit 9d6366b into python:main Nov 17, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant