Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-126491: Increase the threshold for the GC fast cycle test. #126984

Closed
wants to merge 2 commits into from

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Nov 18, 2024

#126502 Modified added an improvement to the behavior of the garbage collector, along with a test to verify that behavior. However, that test fails on iOS and Android (and quite possibly any test run that runs the test suite sequentially); the test imposes a limit of 25k objects, but iOS and Android both generate 25032 objects.

The 32 extra object count seems to be something baked in - if you increase the iteration count of the test to 100k, you get the same 25032 object count on iOS and Android.

Following this comment, this PR increases the threshold to 26k 27k.

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit af3c692 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

!buildbot Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit af3c692 🤖

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@hugovk
Copy link
Member

hugovk commented Nov 18, 2024

There's still a test_incremental_gc_handles_fast_cycle_creation failure on iOS/Android.

(When this is passing, let's queue up a full buildbot session with the 🔨 test-with-buildbots or refleaks label as well.)

@freakboy3742
Copy link
Contributor Author

There's still a test_incremental_gc_handles_fast_cycle_creation failure on iOS/Android.

... wat? Now they're both failing with the same count of 26250? I'll bump to 27k as originally suggested... but Murphy being who he is, I'm guessing that means they'll now both fail with a count 27300... 🤣

@freakboy3742
Copy link
Contributor Author

!builbot iOS

@freakboy3742
Copy link
Contributor Author

!buildbot Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9d5a064 🤖

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9d5a064 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

Looks like Bevedere has obliged us with a full buildbot pass regardless...

@freakboy3742
Copy link
Contributor Author

Ok... I was kidding when I predicted the test failure mode... What on earth is going on?

@freakboy3742
Copy link
Contributor Author

I think I see what is going on now. My original assertion that increasing the loop count to 100k didn't change anything was based on having the assertion still set at 25k, and seeing the same 25,032 failure count. I see now that the GC count is increasing with more iterations. Checking now to see how high the threshold actually is...

@freakboy3742
Copy link
Contributor Author

After further testing, it looks like the limit is a lot more than 30k... but the good news (for me) is that I can reproduce the problem on macOS. Closing this PR; I'll put notes back in the original ticket.

@freakboy3742 freakboy3742 deleted the gc-fast-cycle-fix branch November 19, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants