Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-126316: Make grp.getgrall() thread-safe: add a mutex (#127055) #127104

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[3.13] gh-126316: Make grp.getgrall() thread-safe: add a mutex (#127055) #127104

merged 2 commits into from
Nov 26, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 21, 2024 •
edited by bedevere-app bot
Loading

grpmodule.c is no longer built with the limited C API, since PyMutex is excluded from the limited C API.

(cherry picked from commit 3c2bd66)

@vstinner
pythongh-126316: Make grp.getgrall() thread-safe: add a mutex (python…
c36d77d 
…#127055)

grpmodule.c is no longer built with the limited C API, since PyMutex
is excluded from the limited C API.

(cherry picked from commit 3c2bd66)
@bedevere-app bedevere-app bot mentioned this pull request Nov 21, 2024
Closed
@bedevere-app bedevere-app bot mentioned this pull request Nov 21, 2024
Merged
@vstinner
Copy link
Member Author

Tests / Check if the ABI has changed (pull_request) Failing after 1m

Oh, I suppose that it's the addition of the "id" string which is automatically generated from Argument Clinic :-(

@vstinner
Revert ABI changes
d5a4a4c 
Don't use Argument Clinic for grp.getgrgid() to avoid changing the
ABI (change PyInterpreterState structure by adding an "id"
identifier).
@vstinner vstinner merged commit 9187ac3 into python:3.13 Nov 26, 2024
38 checks passed
@vstinner vstinner deleted the getgrall_mutex13 branch November 26, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @gpshead