Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126883: Add check that timezone fields are in range for datetime.fromisoformat #127242

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

donBarbos
Copy link

@donBarbos donBarbos commented Nov 25, 2024

  1. Update C implementation
  2. Update Python implementation
  3. Add more use cases to tests

Also error output for the time.fromisoformat function was fixed as in datetime.fromisoformat in Python implementation

@bedevere-app
Copy link

bedevere-app bot commented Nov 25, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@pganssle
Copy link
Member

I haven't had a chance for a through review yet, but I'm in favor of the general approach and a casual glance looks good.

Can you add a news blurb (credit yourself appropriately unless you don't want that for some reason), and if you aren't already in ACKS please add yourself there (again unless you don't want to be acknowledged for some reason).

@donBarbos
Copy link
Author

@pganssle done 👍
I think it's now ready for review and merging.
And I'll soon send a PR to solve the rest of the problems described here #127260 and I would be grateful if you answered in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants