GH-126727: Fix test_era_nl_langinfo with Japanese ERAs on Solaris #127327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
Nov 30, 2024
ZeroIntensity
added
needs backport to 3.12
serhiy-storchaka
approved these changes
Dec 5, 2024
|
Thanks @kulikjak for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2024
…is (pythonGH-127327) Fix test_era_nl_langinfo with Japanese ERAs on Solaris (cherry picked from commit d958d9f) Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2024
…is (pythonGH-127327) Fix test_era_nl_langinfo with Japanese ERAs on Solaris (cherry picked from commit d958d9f) Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
|
GH-127645 is a backport of this pull request to the 3.13 branch. |
|
GH-127646 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 5, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Solaris, Japanese ERAs start with the year 1927, and thus there's less of them.