gh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios
#127336
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rruuaanng
changed the title
ZeroIntensity
approved these changes
Nov 28, 2024
Misc/NEWS.d/next/Library/2024-11-27-23-13-21.gh-issue-127335.IiqYeX.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2024-11-27-23-13-21.gh-issue-127335.IiqYeX.rst
Outdated
Show resolved
Hide resolved
erlend-aasland
changed the title
TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios
erlend-aasland
approved these changes
Nov 29, 2024
|
As you've been told previously, please spell out the actual change in the PR title. |
LocoabordoR8
reviewed
Dec 9, 2024
| @@ -0,0 +1,2 @@ | |||
| Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the | |||
| :mod:`termios` module. | |||
There was a problem hiding this comment.
Wait, I don't seem to understand your comment, what did you expect? I read the files you provided, but it seems that they are related to the Linux driver model. If you have questions about this, I can contact the downstream team of the corresponding subsystem for you.
| @@ -0,0 +1,2 @@ | |||
| Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the | |||
There was a problem hiding this comment.
Suggested change
| Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the | |
| Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the |
There was a problem hiding this comment.
They seem to make no difference, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIOCM_OUT1,TIOCM_OUT2, andTIOCM_LOOPconstants totermios#127335Mainly synchronize the latest modem lines constants to the
termiosmodule.