-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127335: Add TIOCM_OUT1
, TIOCM_OUT2
, and TIOCM_LOOP
to termios
#127336
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
As far as I can tell, we don't have explicit tests or documentation for any of the other macros, so I think we're good.
Misc/NEWS.d/next/Library/2024-11-27-23-13-21.gh-issue-127335.IiqYeX.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2024-11-27-23-13-21.gh-issue-127335.IiqYeX.rst
Outdated
Show resolved
Hide resolved
TIOCM_OUT1
, TIOCM_OUT2
, and TIOCM_LOOP
to termios
As you've been told previously, please spell out the actual change in the PR title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,2 @@ | |||
Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the | |||
:mod:`termios` module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,2 @@ | |||
Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the | |
Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the |
TIOCM_OUT1
,TIOCM_OUT2
, andTIOCM_LOOP
constants totermios
#127335Mainly synchronize the latest modem lines constants to the
termios
module.