gh-127190: Fix local_setattro() error handling

[vstinner]

Don't make the assumption that the 'name' argument is a string. Use repr() to format the 'name' argument instead.

• Issue: Segfault from asyncio.events._running_loop.__setattr__ with invalid name #127190

[vstinner]

cc @ZeroIntensity @sobolevn

[ZeroIntensity]

The fix and test both look fine, but how come we're skipping a blurb entry?

[vstinner]

The fix and test both look fine, but how come we're skipping a blurb entry?

I don't think that regular users pass objects with a compare function which always compare to true. If you use setattr(), the "lying" object is rejected (no bug). So I don't think that it's useful to document this change for end users.

[ZeroIntensity]

LGTM

[sobolevn]

Thank you!

[miss-islington-app]

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

[bedevere-app]

GH-127367 is a backport of this pull request to the 3.13 branch.

[bedevere-app]

GH-127368 is a backport of this pull request to the 3.12 branch.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.12 has failed when building commit 7d175ca.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1185/builds/1090) and take a look at the build logs.
4. Check if the failure is related to this commit (7d175ca) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1185/builds/1090

Failed tests:

• test.test_multiprocessing_spawn.test_processes

Failed subtests:

• test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.12.billenstein-macos/build/Lib/test/_test_multiprocessing.py", line 1479, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>

[ZeroIntensity]

I don't think that's related.