Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-127385: Add F_DUPFD_QUERY to fcntl #127386

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

gh-127385: Add F_DUPFD_QUERY to fcntl #127386

wants to merge 9 commits into from
+8 −0

Conversation

rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Nov 29, 2024 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 29, 2024
Open
ZeroIntensity
ZeroIntensity previously requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is trying to do too many things. I don't really see the need for the switch to a new macro, but if we do end up doing that, it should be in another PR. Please revert that and keep this focused on the one new macro.

@rruuaanng
Copy link
Contributor Author

@ZeroIntensity
I think you are right. Can you help me convert it into a draft? I'm mobile now.

@ZeroIntensity ZeroIntensity marked this pull request as draft November 29, 2024 06:28
@rruuaanng rruuaanng marked this pull request as ready for review November 29, 2024 06:43
@erlend-aasland erlend-aasland dismissed ZeroIntensity’s stale review November 29, 2024 08:09

The requested changes were addressed

@erlend-aasland
Copy link
Contributor

This PR is trying to do too many things. I don't really see the need for the switch to a new macro, but if we do end up doing that, it should be in another PR. Please revert that and keep this focused on the one new macro.

@rruuaanng, please take Peter's words into account for future contributions. That piece of advice is also spelled out in the devguide.

@erlend-aasland
Copy link
Contributor

I'll land this in a day or two.

@erlend-aasland erlend-aasland self-assigned this Nov 29, 2024
@rruuaanng
Copy link
Contributor Author

This PR is trying to do too many things. I don't really see the need for the switch to a new macro, but if we do end up doing that, it should be in another PR. Please revert that and keep this focused on the one new macro.

@rruuaanng, please take Peter's words into account for future contributions. That piece of advice is also spelled out in the devguide.

Yes, So I've completed his suggestion. I almost forgot it in the process :)

@erlend-aasland erlend-aasland changed the title gh-127385: Add latest F_DUPFD_QUERY constants to fcntl module gh-127385: Add F_DUPFD_QUERY to fcntl Nov 29, 2024
@erlend-aasland erlend-aasland linked an issue Nov 29, 2024 that may be closed by this pull request
Add F_DUPFD_QUERY to fcntl #127385
Open
ZeroIntensity
ZeroIntensity approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@rruuaanng
Copy link
Contributor Author

Hold on, I need to add a document for fcntl, and I found the addition log in the existing documentation. And I confirmed that there is no corresponding document for my other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add F_DUPFD_QUERY to fcntl
3 participants
@rruuaanng @erlend-aasland @ZeroIntensity