gh-127443: fix some entries in Doc/data/refcounts.dat
#127451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
Nov 30, 2024
ZeroIntensity
added
needs backport to 3.12
Eclips4
approved these changes
Nov 30, 2024
This was referenced Dec 1, 2024
|
@Eclips4 I fixed some additional entries that my tool didn't find (I hadn't implemented the check yesterday) |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 2, 2024
…GH-127451) Fix incorrect entries in `Doc/data/refcounts.dat` (cherry picked from commit 1f8267b) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 2, 2024
…GH-127451) Fix incorrect entries in `Doc/data/refcounts.dat` (cherry picked from commit 1f8267b) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-127496 is a backport of this pull request to the 3.13 branch. |
|
GH-127497 is a backport of this pull request to the 3.12 branch. |
|
Thank you, Bénédikt! I'd prefer to backport this to 3.12 and 3.13, as these entries are incorrect (and this applies to both 3.12 and 3.13). |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Dec 2, 2024
…#127451) Fix incorrect entries in `Doc/data/refcounts.dat`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some entries that were detected by my linter (still in progress). I suspect more entries will be fixed when the tool is ready, but I think we can already fix those.
Doc/data/refcounts.dat#127443📚 Documentation preview 📚: https://cpython-previews--127451.org.readthedocs.build/