Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces #127575

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Dec 3, 2024

This PR fixes scripts iOS/Resources/bin directory to allow arguments with spaces.

Fixes #127434

Copy link

cpython-cla-bot bot commented Dec 3, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Dec 3, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@FeodorFitsner
Copy link
Contributor Author

cc @freakboy3742

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - the code changes look fine; from a process perspective, all changes to Python require a NEWS entry. Bevedere has provided a link to an online tool that can be used to add one, or you can set up the blurb tool in your own environment.

@bedevere-app
Copy link

bedevere-app bot commented Dec 3, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

…e-127434.RjkGT_.rst

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@freakboy3742 freakboy3742 added the needs backport to 3.13 bugs and security fixes label Dec 5, 2024
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@freakboy3742
Copy link
Contributor

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9356299 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor

I'm just waiting on an iOS buildbot job to 100% confirm that this works; for some reason, the buildbots doesn't seem to be starting jobs at present...

@freakboy3742 freakboy3742 merged commit 6cf7794 into python:main Dec 5, 2024
43 of 45 checks passed
@miss-islington-app
Copy link

Thanks @FeodorFitsner for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @FeodorFitsner and @freakboy3742, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6cf77949fba7b44f6885794b2028f091f42f5d6c 3.13

freakboy3742 pushed a commit to freakboy3742/cpython that referenced this pull request Dec 5, 2024
…ow arguments with spaces (pythonGH-127575)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <feodor@appveyor.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 5, 2024

GH-127624 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 5, 2024
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang Installed 3.x has failed when building commit 6cf7794.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/350/builds/6971) and take a look at the build logs.
  4. Check if the failure is related to this commit (6cf7794) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/350/builds/6971

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 37, done.        
remote: Counting objects:   2% (1/37)        
remote: Counting objects:   5% (2/37)        
remote: Counting objects:   8% (3/37)        
remote: Counting objects:  10% (4/37)        
remote: Counting objects:  13% (5/37)        
remote: Counting objects:  16% (6/37)        
remote: Counting objects:  18% (7/37)        
remote: Counting objects:  21% (8/37)        
remote: Counting objects:  24% (9/37)        
remote: Counting objects:  27% (10/37)        
remote: Counting objects:  29% (11/37)        
remote: Counting objects:  32% (12/37)        
remote: Counting objects:  35% (13/37)        
remote: Counting objects:  37% (14/37)        
remote: Counting objects:  40% (15/37)        
remote: Counting objects:  43% (16/37)        
remote: Counting objects:  45% (17/37)        
remote: Counting objects:  48% (18/37)        
remote: Counting objects:  51% (19/37)        
remote: Counting objects:  54% (20/37)        
remote: Counting objects:  56% (21/37)        
remote: Counting objects:  59% (22/37)        
remote: Counting objects:  62% (23/37)        
remote: Counting objects:  64% (24/37)        
remote: Counting objects:  67% (25/37)        
remote: Counting objects:  70% (26/37)        
remote: Counting objects:  72% (27/37)        
remote: Counting objects:  75% (28/37)        
remote: Counting objects:  78% (29/37)        
remote: Counting objects:  81% (30/37)        
remote: Counting objects:  83% (31/37)        
remote: Counting objects:  86% (32/37)        
remote: Counting objects:  89% (33/37)        
remote: Counting objects:  91% (34/37)        
remote: Counting objects:  94% (35/37)        
remote: Counting objects:  97% (36/37)        
remote: Counting objects: 100% (37/37)        
remote: Counting objects: 100% (37/37), done.        
remote: Compressing objects:   7% (1/13)        
remote: Compressing objects:  15% (2/13)        
remote: Compressing objects:  23% (3/13)        
remote: Compressing objects:  30% (4/13)        
remote: Compressing objects:  38% (5/13)        
remote: Compressing objects:  46% (6/13)        
remote: Compressing objects:  53% (7/13)        
remote: Compressing objects:  61% (8/13)        
remote: Compressing objects:  69% (9/13)        
remote: Compressing objects:  76% (10/13)        
remote: Compressing objects:  84% (11/13)        
remote: Compressing objects:  92% (12/13)        
remote: Compressing objects: 100% (13/13)        
remote: Compressing objects: 100% (13/13), done.        
remote: Total 21 (delta 15), reused 12 (delta 8), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
fatal: update_ref failed for ref 'HEAD': cannot lock ref 'HEAD': Unable to create '/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/.git/HEAD.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

freakboy3742 added a commit that referenced this pull request Dec 5, 2024
…uments with spaces (GH-127575) (#127624)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <feodor@appveyor.com>
@freakboy3742
Copy link
Contributor

The Fedora build failure seems to be a transient network failure, not related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS clang aliases crash with "invalid directory name" error if called with arguments having spaces
3 participants