gh-127434: Fix iOS `xcrun --sdk` clang/ar scripts to allow arguments with spaces #127575

FeodorFitsner · 2024-12-03T18:27:16Z

This PR fixes scripts iOS/Resources/bin directory to allow arguments with spaces.

Fixes #127434

Issue: iOS clang aliases crash with "invalid directory name" error if called with arguments having spaces #127434

cpython-cla-bot · 2024-12-03T18:27:20Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2024-12-03T18:27:24Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

FeodorFitsner · 2024-12-03T18:29:18Z

cc @freakboy3742

freakboy3742

Thanks for the contribution - the code changes look fine; from a process perspective, all changes to Python require a NEWS entry. Bevedere has provided a link to an online tool that can be used to add one, or you can set up the blurb tool in your own environment.

bedevere-app · 2024-12-03T22:58:12Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

…-aliases

bedevere-app · 2024-12-04T17:46:56Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Misc/NEWS.d/next/Core_and_Builtins/2024-12-04-09-52-08.gh-issue-127434.RjkGT_.rst

…e-127434.RjkGT_.rst Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

freakboy3742

Thanks for the fix!

freakboy3742 · 2024-12-05T00:35:23Z

!buildbot iOS

bedevere-bot · 2024-12-05T00:35:26Z

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9356299 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

iOS ARM64 Simulator PR

freakboy3742 · 2024-12-05T00:50:06Z

I'm just waiting on an iOS buildbot job to 100% confirm that this works; for some reason, the buildbots doesn't seem to be starting jobs at present...

miss-islington-app · 2024-12-05T03:00:23Z

Thanks @FeodorFitsner for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2024-12-05T03:00:27Z

Sorry, @FeodorFitsner and @freakboy3742, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6cf77949fba7b44f6885794b2028f091f42f5d6c 3.13

…ow arguments with spaces (pythonGH-127575) Added shell escaping to ensure iOS compiler shims can accept arguments with spaces. (cherry picked from commit 6cf7794) Co-authored-by: Feodor Fitsner <feodor@appveyor.com>

bedevere-app · 2024-12-05T03:05:52Z

GH-127624 is a backport of this pull request to the 3.13 branch.

bedevere-bot · 2024-12-05T03:18:56Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang Installed 3.x has failed when building commit 6cf7794.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/350/builds/6971) and take a look at the build logs.
Check if the failure is related to this commit (6cf7794) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/350/builds/6971

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 37, done.        
remote: Counting objects:   2% (1/37)        
remote: Counting objects:   5% (2/37)        
remote: Counting objects:   8% (3/37)        
remote: Counting objects:  10% (4/37)        
remote: Counting objects:  13% (5/37)        
remote: Counting objects:  16% (6/37)        
remote: Counting objects:  18% (7/37)        
remote: Counting objects:  21% (8/37)        
remote: Counting objects:  24% (9/37)        
remote: Counting objects:  27% (10/37)        
remote: Counting objects:  29% (11/37)        
remote: Counting objects:  32% (12/37)        
remote: Counting objects:  35% (13/37)        
remote: Counting objects:  37% (14/37)        
remote: Counting objects:  40% (15/37)        
remote: Counting objects:  43% (16/37)        
remote: Counting objects:  45% (17/37)        
remote: Counting objects:  48% (18/37)        
remote: Counting objects:  51% (19/37)        
remote: Counting objects:  54% (20/37)        
remote: Counting objects:  56% (21/37)        
remote: Counting objects:  59% (22/37)        
remote: Counting objects:  62% (23/37)        
remote: Counting objects:  64% (24/37)        
remote: Counting objects:  67% (25/37)        
remote: Counting objects:  70% (26/37)        
remote: Counting objects:  72% (27/37)        
remote: Counting objects:  75% (28/37)        
remote: Counting objects:  78% (29/37)        
remote: Counting objects:  81% (30/37)        
remote: Counting objects:  83% (31/37)        
remote: Counting objects:  86% (32/37)        
remote: Counting objects:  89% (33/37)        
remote: Counting objects:  91% (34/37)        
remote: Counting objects:  94% (35/37)        
remote: Counting objects:  97% (36/37)        
remote: Counting objects: 100% (37/37)        
remote: Counting objects: 100% (37/37), done.        
remote: Compressing objects:   7% (1/13)        
remote: Compressing objects:  15% (2/13)        
remote: Compressing objects:  23% (3/13)        
remote: Compressing objects:  30% (4/13)        
remote: Compressing objects:  38% (5/13)        
remote: Compressing objects:  46% (6/13)        
remote: Compressing objects:  53% (7/13)        
remote: Compressing objects:  61% (8/13)        
remote: Compressing objects:  69% (9/13)        
remote: Compressing objects:  76% (10/13)        
remote: Compressing objects:  84% (11/13)        
remote: Compressing objects:  92% (12/13)        
remote: Compressing objects: 100% (13/13)        
remote: Compressing objects: 100% (13/13), done.        
remote: Total 21 (delta 15), reused 12 (delta 8), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
fatal: update_ref failed for ref 'HEAD': cannot lock ref 'HEAD': Unable to create '/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/.git/HEAD.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

…uments with spaces (GH-127575) (#127624) Added shell escaping to ensure iOS compiler shims can accept arguments with spaces. (cherry picked from commit 6cf7794) Co-authored-by: Feodor Fitsner <feodor@appveyor.com>

freakboy3742 · 2024-12-05T05:54:07Z

The Fedora build failure seems to be a transient network failure, not related to this PR.

Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces

c728ae8

FeodorFitsner requested a review from freakboy3742 as a code owner December 3, 2024 18:27

bedevere-app bot mentioned this pull request Dec 3, 2024

iOS clang aliases crash with "invalid directory name" error if called with arguments having spaces #127434

Closed

bedevere-app bot added the awaiting review label Dec 3, 2024

freakboy3742 requested changes Dec 3, 2024

View reviewed changes

bedevere-app bot removed the awaiting review label Dec 3, 2024

bedevere-app bot added the awaiting changes label Dec 3, 2024

Merge remote-tracking branch 'upstream/main' into ios-fix-xcrun-clang…

e494265

…-aliases

Create 2024-12-04-09-52-08.gh-issue-127434.RjkGT_.rst

ab2ddf7

freakboy3742 reviewed Dec 4, 2024

View reviewed changes

Misc/NEWS.d/next/Core_and_Builtins/2024-12-04-09-52-08.gh-issue-127434.RjkGT_.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Core_and_Builtins/2024-12-04-09-52-08.gh-issu…

9356299

…e-127434.RjkGT_.rst Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

freakboy3742 added the needs backport to 3.13 bugs and security fixes label Dec 5, 2024

freakboy3742 approved these changes Dec 5, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting changes labels Dec 5, 2024

freakboy3742 merged commit 6cf7794 into python:main Dec 5, 2024
43 of 45 checks passed

bedevere-app bot removed the awaiting merge label Dec 5, 2024

miss-islington-app bot assigned freakboy3742 Dec 5, 2024

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-127434: Fix iOS `xcrun --sdk` clang/ar scripts to allow arguments with spaces #127575

gh-127434: Fix iOS `xcrun --sdk` clang/ar scripts to allow arguments with spaces #127575

FeodorFitsner commented Dec 3, 2024 •

edited by freakboy3742

Loading

cpython-cla-bot bot commented Dec 3, 2024 •

edited

Loading

bedevere-app bot commented Dec 3, 2024

FeodorFitsner commented Dec 3, 2024

freakboy3742 left a comment

bedevere-app bot commented Dec 3, 2024

bedevere-app bot commented Dec 4, 2024

freakboy3742 left a comment

freakboy3742 commented Dec 5, 2024

bedevere-bot commented Dec 5, 2024

freakboy3742 commented Dec 5, 2024

miss-islington-app bot commented Dec 5, 2024

miss-islington-app bot commented Dec 5, 2024

bedevere-app bot commented Dec 5, 2024

bedevere-bot commented Dec 5, 2024

freakboy3742 commented Dec 5, 2024

gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces #127575

gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces #127575

Conversation

FeodorFitsner commented Dec 3, 2024 • edited by freakboy3742 Loading

cpython-cla-bot bot commented Dec 3, 2024 • edited Loading

bedevere-app bot commented Dec 3, 2024

FeodorFitsner commented Dec 3, 2024

freakboy3742 left a comment

Choose a reason for hiding this comment

bedevere-app bot commented Dec 3, 2024

bedevere-app bot commented Dec 4, 2024

freakboy3742 left a comment

Choose a reason for hiding this comment

freakboy3742 commented Dec 5, 2024

bedevere-bot commented Dec 5, 2024

freakboy3742 commented Dec 5, 2024

miss-islington-app bot commented Dec 5, 2024

miss-islington-app bot commented Dec 5, 2024

bedevere-app bot commented Dec 5, 2024

bedevere-bot commented Dec 5, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

freakboy3742 commented Dec 5, 2024

gh-127434: Fix iOS `xcrun --sdk` clang/ar scripts to allow arguments with spaces #127575

gh-127434: Fix iOS `xcrun --sdk` clang/ar scripts to allow arguments with spaces #127575

FeodorFitsner commented Dec 3, 2024 •

edited by freakboy3742

Loading

cpython-cla-bot bot commented Dec 3, 2024 •

edited

Loading