-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127434: Fix iOS xcrun --sdk
clang/ar scripts to allow arguments with spaces
#127575
gh-127434: Fix iOS xcrun --sdk
clang/ar scripts to allow arguments with spaces
#127575
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution - the code changes look fine; from a process perspective, all changes to Python require a NEWS entry. Bevedere has provided a link to an online tool that can be used to add one, or you can set up the blurb
tool in your own environment.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Misc/NEWS.d/next/Core_and_Builtins/2024-12-04-09-52-08.gh-issue-127434.RjkGT_.rst
Outdated
Show resolved
Hide resolved
…e-127434.RjkGT_.rst Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
!buildbot iOS |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9356299 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
I'm just waiting on an iOS buildbot job to 100% confirm that this works; for some reason, the buildbots doesn't seem to be starting jobs at present... |
Thanks @FeodorFitsner for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @FeodorFitsner and @freakboy3742, I could not cleanly backport this to
|
…ow arguments with spaces (pythonGH-127575) Added shell escaping to ensure iOS compiler shims can accept arguments with spaces. (cherry picked from commit 6cf7794) Co-authored-by: Feodor Fitsner <feodor@appveyor.com>
GH-127624 is a backport of this pull request to the 3.13 branch. |
|
This PR fixes scripts
iOS/Resources/bin
directory to allow arguments with spaces.Fixes #127434
clang
aliases crash with "invalid directory name" error if called with arguments having spaces #127434