gh-128062: Fix the font size and shortcut display of the turtledemo menu #128063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s too large and the shortcut key is displayed inaccurately
Misc/NEWS.d/next/Library/2024-12-18-10-18-55.gh-issue-128062.E9oU7-.rst
Outdated
Show resolved
Hide resolved
…9oU7-.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Xiaokang2022
changed the title
turtledemoturtledemo's menu bar to its default value and display the shortcut keys in the correct position
terryjreedy
changed the title
turtledemo's menu bar to its default value and display the shortcut keys in the correct position
|
I fixed title and commit message. The macOS failure seems to be a known unrelated issue, #128069. Merging seems to be blocked until this is fixed. |
terryjreedy
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
On my MacBook Air, with a small screen, fontsize 12 is too small as the default, used for the top bar, appears to be 14. Command+- and Command+= are the keys that work in the text widget. Agree with leaving size alone and using the standard accelerator option.
terryjreedy
added
needs backport to 3.12
|
Thanks @Xiaokang2022 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 19, 2024
…demo menu (pythonGH-128063) Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option. --------- (cherry picked from commit e163e8d) Co-authored-by: Zhikang Yan <2951256653@qq.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
Sorry, @Xiaokang2022 and @terryjreedy, I could not cleanly backport this to |
|
GH-128101 is a backport of this pull request to the 3.13 branch. |
terryjreedy
added a commit
that referenced
this pull request
Dec 19, 2024
…edemo menu (GH-128063) (#128101) gh-128062: Fix the font size and shortcut display of the turtledemo menu (GH-128063) Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option. --------- (cherry picked from commit e163e8d) Co-authored-by: Zhikang Yan <2951256653@qq.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Dec 23, 2024
…demo menu (python#128063) Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option. --------- Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…demo menu (python#128063) Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option. --------- Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.