Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop() #128172

Merged
merged 1 commit into from
Dec 22, 2024
Merged

gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop() #128172

merged 1 commit into from
Dec 22, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Dec 22, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Dec 22, 2024
@graingert graingert mentioned this pull request Dec 22, 2024
Closed
7 tasks
@graingert graingert changed the title fix resource warnings in test_tasks.py gh-127949: fix resource warnings in test_tasks.py due to avoiding a call to get_event_loop() Dec 22, 2024
@graingert graingert marked this pull request as ready for review December 22, 2024 11:05
@kumaraditya303 kumaraditya303 merged commit b66a4ad into python:main Dec 22, 2024
46 checks passed
@graingert graingert deleted the fix-resource-warnings-in-test-tasks branch December 22, 2024 13:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
@graingert @srinivasreddy
pythongh-127949: fix resource warnings in test_tasks.py (python#128172
2ad5c8f 
)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@graingert @srinivasreddy
pythongh-127949: fix resource warnings in test_tasks.py (python#128172
2cebf45 
)
@graingert graingert added the needs backport to 3.13 bugs and security fixes label Mar 27, 2025
@miss-islington-app
Copy link

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2025
@graingert @miss-islington
pythongh-127949: fix resource warnings in test_tasks.py (pythonGH-1…
ac0688b 
…28172)

(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 27, 2025

GH-131805 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2025
@graingert graingert added the needs backport to 3.12 bug and security fixes label Mar 27, 2025
@miss-islington-app
Copy link

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2025
@graingert @miss-islington
pythongh-127949: fix resource warnings in test_tasks.py (pythonGH-1…
89abf3b 
…28172)

(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 27, 2025

GH-131806 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 27, 2025
kumaraditya303 pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @graingert
[3.13] gh-127949: fix resource warnings in test_tasks.py (GH-128172) (
924a6ce 
#131805)

gh-127949: fix resource warnings in `test_tasks.py` (GH-128172)
(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
kumaraditya303 added a commit that referenced this pull request Mar 28, 2025
@miss-islington @graingert @kumaraditya303
[3.12] gh-127949: fix resource warnings in test_tasks.py (GH-128172) (
d4ddc03 
#131806)

* gh-127949: fix resource warnings in `test_tasks.py` (GH-128172)
(cherry picked from commit b66a4ad)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @kumaraditya303