Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-69001: Convert links to more usable buttons #129591

Merged
merged 5 commits into from
Feb 20, 2025
Merged

gh-69001: Convert links to more usable buttons #129591

merged 5 commits into from
Feb 20, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Feb 2, 2025 •
edited by bedevere-app bot
Loading

image

Makes it a LOT clearer that they are buttons. (I opened about 15 tabs before I noticed on the current version)

Much better for accessibility as buttons are keyboard usable.

@bedevere-app bedevere-app bot mentioned this pull request Feb 2, 2025
Open
terryjreedy
terryjreedy requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative would be to add 'link underlines' and usually done in text. I believe this can be done at least in a Text widget. But since we have buttons elsewhere, 2 more is fine.

@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

StanFromIreland and others added 3 commits February 4, 2025 16:33
@StanFromIreland @terryjreedy
Update Lib/idlelib/help_about.py
245abe2 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@StanFromIreland @terryjreedy
Update Lib/idlelib/help_about.py
cef6a10 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@StanFromIreland
Terry's suggestion
751c88e
@StanFromIreland
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2025

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from terryjreedy February 4, 2025 16:44
@StanFromIreland
Copy link
Contributor Author

Weird, ubuntu test fails after 7 seconds so I doubt it has anything to do with the PR.

@terryjreedy terryjreedy added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 6, 2025
@terryjreedy terryjreedy mentioned this pull request Feb 8, 2025
Closed
@StanFromIreland StanFromIreland deleted the idle-about branch February 18, 2025 11:07
@StanFromIreland StanFromIreland restored the idle-about branch February 18, 2025 12:29
@StanFromIreland
Copy link
Contributor Author

Accidentally closed, anything left to do here Terry?

terryjreedy
terryjreedy approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at this and other examples of 'About XYZ' panels, I would like to convert all the buttons to underlined links. (I mentioned this idea somewhere on the issue.) This would allow, for instance 'Post questions and comments about IDLE on Python discussions. However, this PR is an improvement on the status quo and it is uncertain when another patch might get merged. So with the understanding that this may be a temporary state, I am merging this.

@terryjreedy terryjreedy enabled auto-merge (squash) February 20, 2025 06:57
@terryjreedy terryjreedy merged commit ed831b9 into python:main Feb 20, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
@StanFromIreland @terryjreedy @miss-islington
pythongh-69001: Convert links to more usable buttons (pythonGH-129591)
f5af085 
In Lib/idlelib/help_about.py, there are 2 links that are not underlined or colored, hence hard to tell that clicking works.  All buttons might get converted to colored and underlined links in the future.
---------
(cherry picked from commit ed831b9)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app
Copy link

bedevere-app bot commented Feb 20, 2025

GH-130338 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
@StanFromIreland @terryjreedy @miss-islington
pythongh-69001: Convert links to more usable buttons (pythonGH-129591)
d550c4b 
In Lib/idlelib/help_about.py, there are 2 links that are not underlined or colored, hence hard to tell that clicking works.  All buttons might get converted to colored and underlined links in the future.
---------
(cherry picked from commit ed831b9)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app
Copy link

bedevere-app bot commented Feb 20, 2025

GH-130339 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 20, 2025
terryjreedy added a commit that referenced this pull request Feb 20, 2025
@miss-islington @StanFromIreland @terryjreedy
[3.12] gh-69001: Convert links to more usable buttons (GH-129591) (#1…
b259b75 
…30339)

gh-69001: Convert links to more usable buttons (GH-129591)

In Lib/idlelib/help_about.py, there are 2 links that are not underlined or colored, hence hard to tell that clicking works.  All buttons might get converted to colored and underlined links in the future.
---------
(cherry picked from commit ed831b9)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Feb 20, 2025
@miss-islington @StanFromIreland @terryjreedy
[3.13] gh-69001: Convert links to more usable buttons (GH-129591) (#1…
270ec26 
…30338)

gh-69001: Convert links to more usable buttons (GH-129591)

In Lib/idlelib/help_about.py, there are 2 links that are not underlined or colored, hence hard to tell that clicking works.  All buttons might get converted to colored and underlined links in the future.
---------
(cherry picked from commit ed831b9)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@freakboy3742 freakboy3742 mentioned this pull request Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @terryjreedy @encukou