bpo-36742: Fixes handling of pre-normalization characters in urlsplit() #13017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamanu
approved these changes
Apr 30, 2019
Contributor
eamanu
left a comment
eamanu
left a comment
There was a problem hiding this comment.
LGTM.
I test it in a Debian 4.9.168-1 x86_64 GNU/Linux and the bugs is fixed.
Tests run ok.
Contributor
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-13023 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 30, 2019
…() (pythonGH-13017) (cherry picked from commit d537ab0) Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 30, 2019
…() (pythonGH-13017) (cherry picked from commit d537ab0) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-13024 is a backport of this pull request to the 3.6 branch. |
Contributor
|
Sorry, @zooba, I could not cleanly backport this to |
|
GH-13025 is a backport of this pull request to the 2.7 branch. |
zooba
added a commit
that referenced
this pull request
May 1, 2019
zooba
added a commit
to zooba/cpython
that referenced
this pull request
May 1, 2019
ned-deily
pushed a commit
that referenced
this pull request
May 2, 2019
larryhastings
pushed a commit
that referenced
this pull request
Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36742