gh-130250: use support.swap_attr() in test and don't assume we're beginning with a clean system state #130342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Feb 20, 2025
•
iritkatriel
commented
- Issue: traceback.print_last behaving differently across python versions #130250
iritkatriel
added
skip news
needs backport to 3.12
iritkatriel
force-pushed
the
fix-test
branch
from
abdabd0 to
58196ed
Compare
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 58196ed 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130342%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
serhiy-storchaka
approved these changes
Feb 20, 2025
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 20, 2025
…re beginning with a clean system state (pythonGH-130342) (cherry picked from commit 048ee2d) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-130344 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 20, 2025
…re beginning with a clean system state (pythonGH-130342) (cherry picked from commit 048ee2d) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-130345 is a backport of this pull request to the 3.12 branch. |
|
@iritkatriel Thanks for the fix on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.