Skip to content

GH-91079: Fix stack overflow on AMD LTO linux #130369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

GH-91079: Fix stack overflow on AMD LTO linux #130369

wants to merge 2 commits into from

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Feb 20, 2025 •
edited
Loading

In #130007 we increased the default stack size from an estimated 4MB to 5MB.
This PR resets it to 3M.

This is a temporary fix until #130396 is implemented

@bedevere-app bedevere-app bot mentioned this pull request Feb 20, 2025
Open
@markshannon
Copy link
Member Author

!buildbot fedora lto

@markshannon
Copy link
Member Author

!buildbot "AMD64 Fedora Stable LTO"

@markshannon
Copy link
Member Author

!buildbot LTO

brandtbucher
brandtbucher approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@markshannon
Copy link
Member Author

!buildbot Fedora.*LTO

@markshannon
Copy link
Member Author

#130398 fixes the same issue and a lot more.

@markshannon markshannon deleted the fix-lto-stack branch February 27, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @brandtbucher