Skip to content

gh-124878: Add temporary TSAN suppression for free_threadstate #130602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 26, 2025

The race condition with free_threadstate and daemon threads exists in both the free threading and default builds. We were missing a suppression in the default build.

The race condition with `free_threadstate` and daemon threads exists in
both the free threading and default builds. We were missing a
suppression in the default build.
@colesbury colesbury added skip news needs backport to 3.13 bugs and security fixes labels Feb 26, 2025
@colesbury colesbury requested a review from mpage February 26, 2025 20:41
@colesbury colesbury changed the title gh-124878: Add temporary suppression for free_threadstate gh-124878: Add temporary TSAN suppression for free_threadstate Feb 26, 2025
@colesbury colesbury marked this pull request as ready for review February 26, 2025 21:08
@colesbury colesbury merged commit cc17307 into python:main Feb 28, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-124878-tsan-skip branch February 28, 2025 14:27
@miss-islington-app
Copy link

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cc17307faaa248535c65f6a7668e06dc8ef04575 3.13

colesbury added a commit to colesbury/cpython that referenced this pull request Feb 28, 2025
…dstate (pythongh-130602)

The race condition with `free_threadstate` and daemon threads exists in
both the free threading and default builds. We were missing a
suppression in the default build.
(cherry picked from commit cc17307)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

GH-130687 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 28, 2025
colesbury added a commit that referenced this pull request Feb 28, 2025
…gh-130602) (gh-130687)

The race condition with `free_threadstate` and daemon threads exists in
both the free threading and default builds. We were missing a
suppression in the default build.
(cherry picked from commit cc17307)
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…ythongh-130602)

The race condition with `free_threadstate` and daemon threads exists in
both the free threading and default builds. We were missing a
suppression in the default build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants