-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128364: Fix flaky test_timeout
test
#130724
Conversation
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to using events instead of sleep
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
(cherry picked from commit cfa0b1d) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-130728 is a backport of this pull request to the 3.13 branch. |
(cherry picked from commit cfa0b1d) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-130729 is a backport of this pull request to the 3.12 branch. |
|
|
An error looks like
(oh, the posts extract this for you — that's nice. I went and dug it up in the logs) |
Ok, I'm going to revert the PR |
Why do we need the multiprocessing manager? (edit: I see it's to get the right |
…)" Change broke Android and iOS buildbots that do not have multiprocessing. This reverts commit cfa0b1d.
|
|
|
) Change broke Android and iOS buildbots that do not have multiprocessing. This reverts commit cfa0b1d.
…)" (pythongh-130732) Change broke Android and iOS buildbots that do not have multiprocessing. This reverts commit cfa0b1d. (cherry picked from commit 5221d9c) Co-authored-by: Sam Gross <colesbury@gmail.com>
…)" (pythongh-130732) Change broke Android and iOS buildbots that do not have multiprocessing. This reverts commit cfa0b1d. (cherry picked from commit 5221d9c) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
|
|
|
|
test_concurrent_futures.test_wait.ThreadPoolWaitTests.test_timeout
flakes frequently on free-threaded Windows x64 #128364