GH-130090: build time analysis #131005
Closed
GH-130090: build time analysis #131005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for _freeze_module in case of clang-cl to speed up the build
Speeds up both MSVC and clang-cl builds. Should most probably done in a separate PR and issue, though.
I've previously gotten compile errors from clang, because the needed intrinsics were not available without that option. Cannot reproduce anymore. Most probably, because I've upgraded to Visual Studio 17.13.0 Preview 5.0, which now ships with clang 19.1.1 instead of 18.1.8 and they've done that for compatibility with MSVC? Anyway, let's keep the PR small :)
This reverts commit 26fb51f. Shall be done in a separate PR.
This better matches the behaviour of build.bat in case of MSVC PGO builds.
and make it a target with inputs and outputs
because the name is too MSVC specific
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
This was referenced Mar 9, 2025
chris-eibl
commented
Mar 9, 2025
| @@ -23,7 +23,7 @@ extern "C" { | |||
| declaration \ | |||
| _GENERATE_DEBUG_SECTION_LINUX(name) | |||
|
|
|||
| #if defined(MS_WINDOWS) | |||
| #if defined(MS_WINDOWS)&& !defined(__clang__) | |||
There was a problem hiding this comment.
Interestingly, for debug builds I now need this, too. Never needed before, see #130040 (comment). Will anyway come with that PR...
chris-eibl
commented
Mar 9, 2025
| @@ -420,6 +420,7 @@ | |||
| <ClCompile Include="..\Modules\blake2module.c"> | |||
| <PreprocessorDefinitions Condition="'$(Platform)' == 'x64'">HACL_CAN_COMPILE_SIMD128;%(PreprocessorDefinitions)</PreprocessorDefinitions> | |||
| <PreprocessorDefinitions Condition="'$(Platform)' == 'x64'">HACL_CAN_COMPILE_SIMD256;%(PreprocessorDefinitions)</PreprocessorDefinitions> | |||
| <AdditionalOptions Condition="'$(Platform)' == 'x64' and '$(LLVMToolsVersion)' < '19'">/arch:AVX</AdditionalOptions> | |||
chris-eibl
commented
Mar 9, 2025
| @@ -0,0 +1,264 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Not a beauty but it creates the tables for me :)
chris-eibl
commented
Mar 9, 2025
| @@ -167,6 +167,30 @@ public override bool Execute() { | |||
| </Task> | |||
| </UsingTask> | |||
|
|
|||
| <Target Name="BeginTimeStamp" BeforeTargets="PrepareForBuild"> | |||
There was a problem hiding this comment.
Only needed for detailed timings per project. Could be guarded behind a Condition="'$(PrintBuildTimeStamps)' == 'true'", in case this shall be merged.
chris-eibl
commented
Mar 9, 2025
| from datetime import datetime, date, time | ||
|
|
||
| # Verstrichene Zeit 00:00:00.74 | ||
| msbuild_time_str = "Verstrichene Zeit" |
There was a problem hiding this comment.
That's the thing I dislike most: msbuild does this localized :(
chris-eibl
changed the title
|
Closing, since this served its purpose. Build time analysis is done, in case someone else ever wants to do something like that: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I generated the tables in #130090.
What to do with it?
Don't know, whether we want anything of that branch. Most probably just close.