Skip to content

gh-70647: Raise a more informative error for when date is out of range #131335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2025
Merged

gh-70647: Raise a more informative error for when date is out of range #131335

merged 4 commits into from
Mar 21, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Mar 16, 2025 •
edited
Loading

Finishes off #116184 (Hope Gregor doesn't mind :-)

@bedevere-app bedevere-app bot mentioned this pull request Mar 16, 2025
Open
@StanFromIreland
Copy link
Contributor Author

Requesting @pitrou @gpshead

gpshead
gpshead requested changes Mar 16, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Mar 16, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Mar 16, 2025

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from gpshead March 16, 2025 19:55
@StanFromIreland
Copy link
Contributor Author

@gpshead Are there any other requested changes?

@gpshead gpshead merged commit e0fda79 into python:main Mar 21, 2025
45 of 46 checks passed
@gpshead gpshead mentioned this pull request Mar 21, 2025
Closed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@StanFromIreland @seehwan80
pythongh-70647: Raise a more informative error for when date is out o…
13f1c3c 
…f range (pythonGH-131335)

More informative error messages mean less debugging what went wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @gpshead