Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36778: Avoid functools in encodings.cp65001 #13211

Closed
wants to merge 1 commit into from
Closed

bpo-36778: Avoid functools in encodings.cp65001 #13211

wants to merge 1 commit into from

Conversation

paulmon
Copy link
Contributor

@paulmon paulmon commented May 8, 2019 •
edited by bedevere-bot
Loading

based on #13110

Replace functools.partial() with lambda to reduce the number of
imports at startup. Avoid the following imports at startup:

_collections
_functools
_heapq
_operator
collections
functools
heapq
itertools
keyword
operator
reprlib

https://bugs.python.org/issue36778

@paulmon
Copy link
Contributor Author

paulmon commented May 8, 2019

Still seeing one failure in my local test pass

FAIL: test_incremental_surrogatepass (test.test_codecs.CP65001Test)

Traceback (most recent call last):
File "C:\master\pythond\lib\test\test_codecs.py", line 436, in test_incremental_surrogatepass
self.assertEqual(dec.decode(data[i:], True), '\uD901')
AssertionError: '' != '\ud901'

  • \ud901

@paulmon paulmon closed this May 10, 2019
@paulmon paulmon deleted the cp65001_no_functools branch May 10, 2019 00:37
@vstinner
Copy link
Member

I merged my PR #13230 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmon @vstinner @the-knights-who-say-ni @bedevere-bot