gh-131798: JIT: Split CALL_TYPE_1 into several uops
#132419
Conversation
| sym_set_null(null); | ||
| } | ||
|
|
||
| op(_GUARD_CALLABLE_TYPE_1, (callable, unused, unused2 -- callable, unused, unused2)) { |
There was a problem hiding this comment.
I am not entirely sure why I cannot do this here:
| op(_GUARD_CALLABLE_TYPE_1, (callable, unused, unused2 -- callable, unused, unused2)) { | |
| op(_GUARD_CALLABLE_TYPE_1, (callable, unused, unused -- callable, unused, unused)) { |
I get SyntaxError: Duplicate name unused, though bytecodes.c allows it 🤔
There was a problem hiding this comment.
Weird. Maybe unused isn't a meaningful value here like it is in bytecodes.c (maybe @markshannon knows)?
| sym_set_null(null); | ||
| } | ||
|
|
||
| op(_GUARD_CALLABLE_TYPE_1, (callable, unused, unused2 -- callable, unused, unused2)) { |
There was a problem hiding this comment.
Weird. Maybe unused isn't a meaningful value here like it is in bytecodes.c (maybe @markshannon knows)?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
| if (sym_has_type(arg)) { | ||
| res = sym_new_const(ctx, (PyObject *)sym_get_type(arg)); | ||
| } |
There was a problem hiding this comment.
Is there an easy way to test this part? i.e. that the res becomes const? AFAIK there are no other uops/guards that check for instances of type so we can't test it indirectly by checking for removed uops..
This mostly works now, though the there are now two unused stackref variables in
executor_cases.c.h(nullandcallable) and I'm not sure how to convince the cases generator to remove them. I tried:DEAD(x)in the guard uops - does not work because the stack variable also appears in the output of the uop. I also can't easily pop them off the stack since neithernullorcallableis TOS.DEAD(x)from_CALL_TYPE_1: not possible, apparently this is needed before I can setres.I'm out of ideas so if anyone knows how to fix it, I'd love to know :)