Skip to content

gh-132435: Test syntax warnings in a finally block #132436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2025
Merged

gh-132435: Test syntax warnings in a finally block #132436

merged 4 commits into from
Apr 13, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Apr 12, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 12, 2025
Closed
@tomasr8 tomasr8 mentioned this pull request Apr 12, 2025
Merged
serhiy-storchaka
serhiy-storchaka reviewed Apr 12, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Eclips4
Eclips4 approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tomasr8 tomasr8 requested a review from sobolevn April 12, 2025 21:27
@sobolevn
Copy link
Member

Do we need to backport this?

@sobolevn sobolevn enabled auto-merge (squash) April 12, 2025 21:30
@tomasr8
Copy link
Member Author

tomasr8 commented Apr 12, 2025

I would, once #131993 is backported as well.

@Eclips4
Copy link
Member

Eclips4 commented Apr 13, 2025

CI seems stuck. Merging main to restart it.

@tomasr8
Copy link
Member Author

tomasr8 commented Apr 13, 2025

The multiprocessing test failures (ENV_CHANGED) do not seem related. I've also seen them fail on other PRs recently

@serhiy-storchaka
Copy link
Member

While we are here, please add a NEWS entry about emitting compiler warnings twice. This is a user visible change, and can save a day for somebody.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) April 13, 2025 08:38
@tomasr8 tomasr8 added the needs backport to 3.13 bugs and security fixes label Apr 13, 2025
@serhiy-storchaka serhiy-storchaka merged commit 887eabc into python:main Apr 13, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 887eabc5a74316708460120d60d0fa4f8bdf5960 3.13

@tomasr8 tomasr8 deleted the finally-warning branch April 13, 2025 20:51
@tomasr8
Copy link
Member Author

tomasr8 commented Apr 13, 2025

I can backport this tomorrow, unless you beat me to it

@serhiy-storchaka
Copy link
Member

It is a midnight here, so I'll be AFK for next 9-10 hours.

@bedevere-app
Copy link

bedevere-app bot commented Apr 14, 2025

GH-132503 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 14, 2025
serhiy-storchaka pushed a commit that referenced this pull request Apr 14, 2025
@tomasr8
[3.13] gh-132435: Test syntax warnings in a finally block (GH-132436) (…
5f1eaff 
…GH-132503)

(cherry picked from commit 887eabc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@sobolevn sobolevn sobolevn approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomasr8 @sobolevn @Eclips4 @serhiy-storchaka