Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace obsolete platforms with more recent examples #132455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replace obsolete platforms with more recent examples #132455

wants to merge 1 commit into from
+6 −6

Conversation

partev
Copy link
Contributor

@partev partev commented Apr 12, 2025 •
edited by ZeroIntensity
Loading

replace two examples:

  • linux-i586
  • linux-alpha (?)

that are almost never used nowadays with the two most common Linux architectures (x86_64 and ARM64)

  • linux-x86_64
  • linux-aarch64

📚 Documentation preview 📚: https://cpython-previews--132455.org.readthedocs.build/en/132455/library/sysconfig.html#sysconfig.get_platform

StanFromIreland
StanFromIreland reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a cosmetic change IMO, the examples are not wrong.

ZeroIntensity
ZeroIntensity approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

Cosmetic changes generally refer to cosmetic code changes, not documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
awaiting core review skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@partev @ZeroIntensity @StanFromIreland