Skip to content

gh-133351: Fix Cmd completion for lines beginning with ! #133362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

godlygeek
Copy link
Contributor

@godlygeek godlygeek commented May 4, 2025

When a line begins with ! and there's no do_shell method defined, parsecmd returns None as the cmd, which incorrectly leads to None being concatenated to complete_ and triggering a TypeError.

Instead, recognize None as a sentinel that means we should call completedefault, as an empty string already is.

When a line begins with `!` and there's no `do_shell` method defined,
`parsecmd` returns `None` as the `cmd`, which incorrectly leads to
`None` being concatenated to `complete_` and triggering a `TypeError`.

Instead, recognize `None` as a sentinel that means we should call
`completedefault`, as an empty string already is.
@godlygeek
Copy link
Contributor Author

Actually, let me close this and open a new issue for it, since this probably deserves a real news entry unrelated to PDB...

@godlygeek godlygeek closed this May 4, 2025
@gaogaotiantian
Copy link
Member

You can just change the gh issue number.

@godlygeek
Copy link
Contributor Author

Too late, I wasn't sure so I opened #133364 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants