gh-133351: Fix Cmd completion for lines beginning with !
#133362
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a line begins with
!
and there's nodo_shell
method defined,parsecmd
returnsNone
as thecmd
, which incorrectly leads toNone
being concatenated tocomplete_
and triggering aTypeError
.Instead, recognize
None
as a sentinel that means we should callcompletedefault
, as an empty string already is.