Skip to content

gh-133601: Remove deprecated typing.no_type_check_decorator #133602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-133601: Remove deprecated typing.no_type_check_decorator #133602

wants to merge 7 commits into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 7, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 7, 2025
Open
@Eclips4 Eclips4 mentioned this pull request May 7, 2025
Closed
@AlexWaygood AlexWaygood mentioned this pull request May 10, 2025
Closed
picnixz
picnixz reviewed May 10, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update Doc/whatsnew/3.15.rst as well?

@picnixz
Copy link
Member

picnixz commented May 10, 2025

So, vendored typing_extensions of pip seems to use the attribute. Maybe we should fix pip and typing_extensions first with a version guard?

@JelleZijlstra JelleZijlstra mentioned this pull request May 10, 2025
Merged
@JelleZijlstra
Copy link
Member

I submitted a change to typing-extensions to stop unconditionally re-exporting this name. We should probably not merge this until that change to typing-extensions has been released.

@yashwanthatla yashwanthatla mentioned this pull request Jun 21, 2025
Open
@sobolevn sobolevn requested a review from AA-Turner as a code owner September 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @picnixz @JelleZijlstra