gh-133604: remove deprecated java_ver function
#133888
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
| @@ -1908,7 +1908,7 @@ New Deprecations | |||
|
|
|||
| * :mod:`platform`: | |||
|
|
|||
| * Deprecate :func:`~platform.java_ver`, | |||
| * Deprecate :func:`!platform.java_ver`, | |||
There was a problem hiding this comment.
The 3.13 what's new is a historical document, I would leave it unchanged.
There was a problem hiding this comment.
@eendebakpt One of the tests failed because of this. If that's acceptable, I'll keep it.
There was a problem hiding this comment.
@eendebakpt so.. keep '~' with failed test or not?
There was a problem hiding this comment.
It is fine. These are always updated when a function is removed.
Doc/whatsnew/3.15.rst
Outdated
| platform | ||
| -------- | ||
|
|
||
| * The deprecated :func:`!platform.java_ver` function. |
There was a problem hiding this comment.
| * The deprecated :func:`!platform.java_ver` function. | |
| * Removed the deprecated :func:`!platform.java_ver` function. |
To save Benedikt copy-editing it later. (See line 133)
You can also link this pr. (See line 134 as an example)
There was a problem hiding this comment.
@StanFromIreland thank you! done
Lib/platform.py
Outdated
| @@ -31,6 +31,7 @@ | |||
| # | |||
| # <see CVS and SVN checkin messages for history> | |||
| # | |||
| # 1.1.0 - removed deprecated java_ver() | |||
There was a problem hiding this comment.
Not noteworthy enough IMO. These are rarely updated, but it is up to @malemburg in the end.
There was a problem hiding this comment.
No need to add to that list anymore. The checkin messages provide enough history.
There was a problem hiding this comment.
You may want to change # <see CVS and SVN checkin messages for history> to # <see checkin messages for history>
platform.java_ver#133604📚 Documentation preview 📚: https://cpython-previews--133888.org.readthedocs.build/