Skip to content

gh-90871: fix connection backlog offset in asyncio#134392

Merged
ambv merged 13 commits intopython:mainfrom
ChristianHrs:gh-90871
May 21, 2025
Merged

gh-90871: fix connection backlog offset in asyncio#134392
ambv merged 13 commits intopython:mainfrom
ChristianHrs:gh-90871

Conversation

@ChristianHrs
Copy link
Contributor

@ChristianHrs ChristianHrs commented May 20, 2025 •
edited by bedevere-app bot
Loading

ChristianHrs and others added 11 commits May 20, 2025 15:06
@ChristianHrs
pythongh-86802: Fix asyncio memory leak; shielded tasks where cancell…
ab8786a 
…ed log once through the exception handler
@ChristianHrs
Add blurb
b500a1f
@ambv
Fix formatting
37837ed
@ChristianHrs
fix handle case with no exception
0d595af
@ChristianHrs
Fix offset with connection backlog - adapted the tests - created new …
17d39e9 
…tests for 0 and 1 connections
@ChristianHrs
Revert "Fix offset with connection backlog - adapted the tests - crea…
d386169 
…ted new tests for 0 and 1 connections"

This reverts commit 17d39e9.
@ChristianHrs
fix connection backlog offset - updated tests - added tests for 0 and 1
2c603b9
@ChristianHrs
Revert "fix connection backlog offset - updated tests - added tests f…
39f4654 
…or 0 and 1"

This reverts commit 2c603b9.
@ChristianHrs
Revert "pythongh-86802: Fix asyncio memory leak; shielded task except…
5893d43 
…ions log once through the exception handler (pythongh-134331)"

This reverts commit f695eca.
@ChristianHrs
Fix connection backlog offset + updated tests + added test for backlo…
a78bde0 
…g=0 and backlog=1
@ChristianHrs
Merge branch 'pythongh-86802' into pythongh-90871
e871568
@bedevere-app bedevere-app bot mentioned this pull request May 20, 2025
Closed
@kumaraditya303 kumaraditya303 changed the title gh-90871 - Fix connection backlog offset gh-90871: fix connection backlog offset in asyncio May 21, 2025
kumaraditya303
kumaraditya303 approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per FreeBSD docs and https://www.man7.org/linux/man-pages/man2/listen.2.html about backlog, this is correct.

@kumaraditya303 kumaraditya303 linked an issue May 21, 2025 that may be closed by this pull request
asyncio.create_unix_server has an off-by-one error concerning the backlog parameter #90871
Closed
@ambv ambv merged commit 109f759 into python:main May 21, 2025
43 checks passed
@ambv ambv added the needs backport to 3.14 bugs and security fixes label May 21, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented May 21, 2025

Thanks @ChristianHrs for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@ChristianHrs @ambv
@kumaraditya303 @miss-islington
pythongh-90871: fix connection backlog offset in asyncio (pythongh-13…
6abda63 
…4392)

(cherry picked from commit 109f759)

Co-authored-by: Christian Harries <68507104+ChristianHrs@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2025

GH-134421 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
@ambv ambv added the needs backport to 3.13 bugs and security fixes label May 21, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented May 21, 2025

Thanks @ChristianHrs for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-app bot commented May 21, 2025

Sorry, @ChristianHrs and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 109f7597d29f0b504e9b42cb398b44177157abaa 3.13

@ambv
Copy link
Contributor

ambv commented May 21, 2025

To backport to 3.13, we might consider backporting #127532 first.

ambv added a commit that referenced this pull request May 21, 2025
@miss-islington @ChristianHrs
@ambv @kumaraditya303
[3.14] gh-90871: fix connection backlog offset in asyncio (gh-134392) (…
f1a9d89 
…gh-134421)

(cherry picked from commit 109f759)

Co-authored-by: Christian Harries <68507104+ChristianHrs@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@ChristianHrs ChristianHrs deleted the gh-90871 branch May 21, 2025 19:17
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@ChristianHrs @ambv
@kumaraditya303 @lkollar
pythongh-90871: fix connection backlog offset in asyncio (pythongh-13…
d4e56eb 
…4392)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@ChristianHrs @ambv
@kumaraditya303 @Pranjal095
pythongh-90871: fix connection backlog offset in asyncio (pythongh-13…
739c23b 
…4392)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@ChristianHrs @ambv
@kumaraditya303 @taegyunkim
pythongh-90871: fix connection backlog offset in asyncio (pythongh-13…
0855409 
…4392)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Aug 14, 2025

Reminder about backporting. @ChristianHrs @ambv

@emmatyping emmatyping mentioned this pull request Dec 14, 2025
Merged
@kumaraditya303 kumaraditya303 added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Dec 15, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 15, 2025

Thanks @ChristianHrs for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 15, 2025
@ChristianHrs @ambv
@kumaraditya303 @miss-islington
pythongh-90871: fix connection backlog offset in asyncio (pythongh-13…
e0f8b30 
…4392)

(cherry picked from commit 109f759)

Co-authored-by: Christian Harries <68507104+ChristianHrs@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 15, 2025

GH-142739 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 15, 2025
kumaraditya303 added a commit that referenced this pull request Dec 15, 2025
@miss-islington @ChristianHrs
@ambv @kumaraditya303
[3.13] gh-90871: fix connection backlog offset in asyncio (gh-134392) (…
7957bfd 
…#142739)

gh-90871: fix connection backlog offset in asyncio (gh-134392)
(cherry picked from commit 109f759)

Co-authored-by: Christian Harries <68507104+ChristianHrs@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@ambv ambv

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

asyncio.create_unix_server has an off-by-one error concerning the backlog parameter

4 participants

@ChristianHrs @ambv @serhiy-storchaka @kumaraditya303