Skip to content

Fix warnings set but not used [-Wunused-but-set-variable] in remote_debug.h #135290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix warnings set but not used [-Wunused-but-set-variable] in remote_debug.h #135290

merged 1 commit into from
Jun 10, 2025

Conversation

chris-eibl
Copy link
Member

Since #134682 these warnings

Python/remote_debug.h:677:9: warning: variable 'lines_processed' set but not used [-Wunused-but-set-variable]
Python/remote_debug.h:678:9: warning: variable 'matches_found' set but not used [-Wunused-but-set-variable]

show up on build bots, e.g. https://buildbot.python.org/#/builders/441/builds/8081.

Likewise, I see similar warnings in clang-cl based builds on Windows (#131296):

..\Python\remote_debug.h(843,9): warning : variable 'modules_examined' set but not used [-Wunused-but-set-variable] [e:\cpython_clang\PCbuild\pythoncore.vcxproj]
..\Python\remote_debug.h(844,9): warning : variable 'matches_found' set but not used [-Wunused-but-set-variable] [e:\cpython_clang\PCbuild\pythoncore.vcxproj]

@pablogsal I think this is a skip news and a skip issue (even though it should be backported to 3.14)?
Or shall/can I link it to #91048?

@chris-eibl chris-eibl requested a review from pablogsal as a code owner June 9, 2025 08:10
@pablogsal pablogsal added needs backport to 3.14 bugs and security fixes and removed awaiting merge labels Jun 10, 2025
@pablogsal
Copy link
Member

@pablogsal I think this is a skip news and a skip issue (even though it should be backported to 3.14)?

Correct!

@pablogsal pablogsal merged commit 49fc1f2 into python:main Jun 10, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @chris-eibl for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 10, 2025
@chris-eibl @miss-islington
Fix warnings set but not used [-Wunused-but-set-variable] in remote…
1259866 
…_debug.h (pythonGH-135290)

(cherry picked from commit 49fc1f2)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 10, 2025

GH-135319 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 10, 2025
@pablogsal
Copy link
Member

Thanks a lot for the fix @chris-eibl 🚀

pablogsal pushed a commit that referenced this pull request Jun 10, 2025
@miss-islington @chris-eibl
[3.14] Fix warnings set but not used [-Wunused-but-set-variable] in…
84c6fe6 
… remote_debug.h (GH-135290) (#135319)

Fix warnings `set but not used [-Wunused-but-set-variable]` in remote_debug.h (GH-135290)
(cherry picked from commit 49fc1f2)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@chris-eibl chris-eibl deleted the fix_remote_debug_warnings branch June 10, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-eibl @pablogsal