Skip to content

gh-135543: emit sys.remote_exec audit event when sys.remote_exec has been called #135544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 19, 2025
Merged

gh-135543: emit sys.remote_exec audit event when sys.remote_exec has been called #135544

merged 24 commits into from
Jun 19, 2025
+79 −20

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Jun 15, 2025 •
edited by github-actions bot
Loading

Zheaoli added 2 commits June 16, 2025 02:31
@Zheaoli
pythongh-135543: emit sys.remote_exec audit event when sys.remote_exe…
b125c78 
…c has been called

Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
add news
afab662 
Signed-off-by: Manjusaka <me@manjusaka.me>
@bedevere-app bedevere-app bot mentioned this pull request Jun 15, 2025
Closed
@Zheaoli Zheaoli mentioned this pull request Jun 15, 2025
Merged
pablogsal
pablogsal reviewed Jun 15, 2025
View reviewed changes
Zheaoli added 2 commits June 16, 2025 03:09
@Zheaoli
fix code
31c6575 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Merge main
22207f1 
Signed-off-by: Manjusaka <me@manjusaka.me>
sobolevn
sobolevn reviewed Jun 15, 2025
View reviewed changes
vstinner
vstinner reviewed Jun 16, 2025
View reviewed changes
Zheaoli and others added 7 commits June 17, 2025 03:06
@Zheaoli @vstinner
Update Doc/library/sys.rst
55e3470 
Co-authored-by: Victor Stinner <vstinner@python.org>
@Zheaoli @vstinner
Update Doc/library/sys.rst
e3fd3ca 
Co-authored-by: Victor Stinner <vstinner@python.org>
@Zheaoli @vstinner
Update Misc/NEWS.d/next/Core_and_Builtins/2025-06-16-02-31-42.gh-issu…
732e3fd 
…e-135543.6b0HOF.rst

Co-authored-by: Victor Stinner <vstinner@python.org>
@Zheaoli
fix review idea
daed532 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Merge branch 'main' into manjusaka/fix135543
183387a
@Zheaoli
update test
f1c6f03 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Merge branch 'manjusaka/fix135543' of github.com:Zheaoli/cpython into…
baa0032 
… manjusaka/fix135543
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 16, 2025

@vstinner @sobolevn @pablogsal I have updated the test. PTAL when you got time

vstinner
vstinner reviewed Jun 17, 2025
View reviewed changes
Zheaoli added 3 commits June 17, 2025 22:44
@Zheaoli
Fix review idea
b9bc94e 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Fix review idea
b158a2b 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Fix review idea
2394b27 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 17, 2025

@vstinner I have fix the review idea. PTAL when you got time. BTW https://github.com/python/cpython/actions/runs/15710806342/job/44268135397?pr=135544 seems unrelated failed. Would you mind rerunning it for me?

@Zheaoli Zheaoli requested a review from vstinner June 17, 2025 15:21
vstinner
vstinner reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I like the updated code. Another review.

@Zheaoli @vstinner
Update Lib/test/support/__init__.py
9302ef3 
Co-authored-by: Victor Stinner <vstinner@python.org>
@Zheaoli
Fix review idea
914f8a1 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli requested a review from vstinner June 17, 2025 15:41
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 17, 2025

@vstinner PTAL when you got time (lol

vstinner
vstinner approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal: what do you think?

@Zheaoli
Update code
2fcb502 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 18, 2025

@vstinner sorry about this, I update a little bit of code. PTAL

Zheaoli added 2 commits June 18, 2025 22:38
@Zheaoli
Update code
6561e81 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Update code
4e7c384 
Signed-off-by: Manjusaka <me@manjusaka.me>
zooba
zooba reviewed Jun 18, 2025
View reviewed changes
Zheaoli added 2 commits June 19, 2025 02:42
@Zheaoli
fix review idea
20ac399 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
update news
8682689 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli requested a review from zooba June 18, 2025 18:44
@pablogsal
Copy link
Member

LGTM.

@pablogsal: what do you think?

I am ok with this 👍

zooba
zooba reviewed Jun 18, 2025
View reviewed changes
@Zheaoli
fix review idea
60725af 
Signed-off-by: Manjusaka <me@manjusaka.me>
@ericsnowcurrently ericsnowcurrently removed their request for review June 19, 2025 15:00
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jun 19, 2025

@zooba I have updated my PR. PTAL

@zooba
Copy link
Member

zooba commented Jun 19, 2025

LGTM, and I don't think the changes are significant since others signed off, so I'll merge.

@zooba zooba merged commit 1ddfe59 into python:main Jun 19, 2025
40 checks passed
@zooba zooba added the needs backport to 3.14 bugs and security fixes label Jun 19, 2025
@miss-islington-app
Copy link

Thanks @Zheaoli for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2025
@Zheaoli @miss-islington
pythongh-135543: Emit sys.remote_exec audit event when sys.remote_exe…
7d6059d 
…c is called (pythonGH-135544)

(cherry picked from commit 1ddfe59)

Co-authored-by: Nadeshiko Manju <me@manjusaka.me>
@bedevere-app
Copy link

bedevere-app bot commented Jun 19, 2025

GH-135732 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 19, 2025
zooba pushed a commit that referenced this pull request Jun 19, 2025
@miss-islington @Zheaoli
gh-135543: Emit sys.remote_exec audit event when sys.remote_exec is c…
0370cb4 
…alled (GH-135544)

(cherry picked from commit 1ddfe59)

Co-authored-by: Nadeshiko Manju <me@manjusaka.me>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@Zheaoli @lkollar
pythongh-135543: Emit sys.remote_exec audit event when sys.remote_exe…
b1ac1d6 
…c is called (pythonGH-135544)
@Zheaoli Zheaoli deleted the manjusaka/fix135543 branch June 19, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

@vstinner vstinner vstinner approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new audit event for sys.remote_exec()
5 participants
@Zheaoli @pablogsal @zooba @vstinner @sobolevn