gh-136437: Document some os.path functions as requiring pos-only
#136812
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
needs backport to 3.13
bedevere-app
bot
added
awaiting core review
docs
AA-Turner
approved these changes
Jul 19, 2025
Member
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
I think this is a net improvement -- I still have slight reservations about the trailing '/', but we've discussed a couple of mitigations (e.g. in JS). Happy to support this.
A
serhiy-storchaka
approved these changes
Jul 21, 2025
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2025
…nly (pythonGH-136812) (cherry picked from commit b5428bb) Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2025
…nly (pythonGH-136812) (cherry picked from commit b5428bb) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-136944 is a backport of this pull request to the 3.14 branch. |
|
GH-136945 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
Jul 21, 2025
sobolevn
added a commit
that referenced
this pull request
Jul 21, 2025
This was referenced Jul 21, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…g pos-only (pythonGH-136812) (python#136944) pythongh-136437: Document some `os.path` functions as requiring pos-only (pythonGH-136812) (cherry picked from commit b5428bb) Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chirizxc reached out to me and asked to take this issue over. So, here's mine PR :)
I scanned through all
os.pathfunctions that do use different pos-or-keyword parameter name from the documented one. And added/to them. See #136437 (comment)I plan that we can backport this.
The second PR that I am working on is to actually make these functions pos-only in 3.15
os.pathdocumentation vs. runtime #136437📚 Documentation preview 📚: https://cpython-previews--136812.org.readthedocs.build/